flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-05 01:05:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

refs #937 Resolved clazy warnings: miscellaneous.

Browse Source
This commit is contained in:
Mathew Sutcliffe
2017-04-17 00:16:12 +01:00
parent 2134b4e874
commit e3fe8ec39f
24 changed files with 89 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/blackcore/application.cpp
View File

@@ -1022,9 +1022,9 @@ namespace BlackCore
{
if (msgs.isEmpty()) { return; }
if (!msgs.hasErrorMessages()) { return; }
return CApplication::cmdLineErrorMessage(
msgs.toFormattedQString(true)
);
CApplication::cmdLineErrorMessage(
msgs.toFormattedQString(true)
);
}
void CApplication::cmdLineHelpMessage()

1
src/blackcore/application.h
View File

@@ -389,6 +389,7 @@ namespace BlackCore
//! Startup has been completed
//! \remark needs to be triggered by application when it think it is done
//! \fixme http://doc.qt.io/qt-5/signalsandslots.html#signals recommends signals be only emitted by their own class
void startUpCompleted(bool success);
//! Facade started

2
src/blackcore/context/contextaudioproxy.cpp
View File

@@ -144,7 +144,7 @@ namespace BlackCore
void CContextAudioProxy::setMute(bool muted)
{
return this->m_dBusInterface->callDBus(QLatin1String("setMute"), muted);
this->m_dBusInterface->callDBus(QLatin1String("setMute"), muted);
}
bool CContextAudioProxy::isMuted() const

4
src/blackcore/vatsim/networkvatlib.cpp
View File

@@ -292,6 +292,7 @@ namespace BlackCore
std::function<const char **()> CNetworkVatlib::toFSD(const QStringList &qstrList) const
{
QVector<QByteArray> bytesVec;
bytesVec.reserve(qstrList.size());
for (auto i = qstrList.cbegin(); i != qstrList.cend(); ++i)
{
bytesVec.push_back(toFSD(*i));
@@ -299,7 +300,7 @@ namespace BlackCore
return [ cstrVec = QVector<const char *>(), bytesVec = std::move(bytesVec) ]() mutable
{
Q_ASSERT(cstrVec.isEmpty());
Q_ASSERT_X(cstrVec.isEmpty(), Q_FUNC_INFO, "toFSD lambda called twice");
for (auto i = bytesVec.cbegin(); i != bytesVec.cend(); ++i)
{
cstrVec.push_back(i->constData());
@@ -317,6 +318,7 @@ namespace BlackCore
QStringList CNetworkVatlib::fromFSD(const char **cstrArray, int size) const
{
QStringList qstrList;
qstrList.reserve(size);
for (int i = 0; i < size; ++i)
{
qstrList.push_back(fromFSD(cstrArray[i]));