refs #937 Resolved clazy warnings: miscellaneous.

This commit is contained in:
Mathew Sutcliffe
2017-04-17 00:16:12 +01:00
parent 2134b4e874
commit e3fe8ec39f
24 changed files with 89 additions and 65 deletions

View File

@@ -605,6 +605,7 @@ namespace BlackMisc
QStringList CAircraftModelList::toCompleterStrings(bool sorted) const
{
QStringList c;
c.reserve(size());
for (const CAircraftModel &model : *this)
{
c.append(model.getModelString());

View File

@@ -51,6 +51,7 @@ namespace BlackMisc
QStringList CVPilotModelRuleSet::toUpper(const QStringList &stringList)
{
QStringList upper;
upper.reserve(stringList.size());
for (const QString &s : stringList)
{
upper.append(s.toUpper());
@@ -61,6 +62,7 @@ namespace BlackMisc
QStringList CVPilotModelRuleSet::getSortedModelNames() const
{
QStringList ms;
ms.reserve(size());
for (const CVPilotModelRule &rule : (*this))
{
ms.append(rule.getModelName());

View File

@@ -103,7 +103,7 @@ namespace BlackMisc
void CRemoteAircraftAware::updateMarkAllAsNotRendered()
{
Q_ASSERT_X(this->m_remoteAircraftProvider, Q_FUNC_INFO, "No object available");
return this->m_remoteAircraftProvider->updateMarkAllAsNotRendered();
this->m_remoteAircraftProvider->updateMarkAllAsNotRendered();
}
bool CRemoteAircraftAware::isRemoteAircraftSupportingParts(const CCallsign &callsign) const

View File

@@ -44,7 +44,7 @@ namespace BlackMisc
while (!ts.atEnd())
{
QString pathToCheck = ts.readLine();
if (QFileInfo(pathToCheck).exists()) { lastLine = pathToCheck; }
if (QFileInfo::exists(pathToCheck)) { lastLine = pathToCheck; }
}
return lastLine;
}