flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-03-22 14:55:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed buggy implementation of CPhysicalQuantity::lessThan.

Browse Source 
This bug could cause a variant containing a list containing a null PQ
to compare equal to a variant containing a list containing a non-null PQ.
This commit is contained in:
Mat Sutcliffe
2019-03-29 00:17:18 +00:00
parent 38fe2d1c49
commit e5e6c53c82
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/blackmisc/pq/physicalquantity.cpp
View File

@@ -222,7 +222,10 @@ namespace BlackMisc
bool CPhysicalQuantity<MU, PQ>::lessThan(const CPhysicalQuantity<MU, PQ> &other) const
{
if (*this == other) return false;
if (this->isNull() || other.isNull()) return false;
if (isNull() < other.isNull()) { return true; }
if (isNull() > other.isNull()) { return false; }
if (isNull() && other.isNull()) { return false; }
return (m_value < other.value(m_unit));
}