flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-27 11:05:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed buggy implementation of CPhysicalQuantity::lessThan.

Browse Source 
This bug could cause a variant containing a list containing a null PQ
to compare equal to a variant containing a list containing a non-null PQ.
This commit is contained in:
Mat Sutcliffe
2019-03-29 00:17:18 +00:00
parent 38fe2d1c49
commit e5e6c53c82
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/blackmisc/pq/testphysicalquantities/testphysicalquantities.cpp
View File

@@ -96,6 +96,14 @@ namespace BlackMiscTest
CFrequencyUnit fu1 = CFrequencyUnit::Hz();
QVERIFY2(fu1 != du1, "Hz must not be meter");
// null comparisons
const CLength null(CLength::null());
const CLength nonNull(1, CLengthUnit::m());
QVERIFY2(null == CLength::null(), "null is equal to null");
QVERIFY2(!(null < CLength::null()), "null is equivalent to null");
QVERIFY2(null != nonNull, "null is not equal to non-null");
QVERIFY2((null < nonNull) != (null > nonNull), "null is ordered wrt non-null");
}
void CTestPhysicalQuantities::lengthBasics()