mirror of
https://github.com/swift-project/pilotclient.git
synced 2026-03-31 21:15:33 +08:00
Move function-scope static QThreadStorage objects to namespace scope
to ensure destruction after all function-scope statics and avoid warning "thread exited after QThreadStorage destroyed".
This commit is contained in:
@@ -50,6 +50,9 @@ namespace BlackMisc
|
||||
//! \threadsafe
|
||||
inline std::mt19937 &defaultRandomGenerator()
|
||||
{
|
||||
//! \fixme Move rng to namespace scope to ensure destruction after function-local statics
|
||||
//! and avoid warning "thread exited after QThreadStorage destroyed".
|
||||
//! This will require careful thought about linkage.
|
||||
static QThreadStorage<std::mt19937> rng;
|
||||
if (rng.hasLocalData()) { rng.setLocalData(std::mt19937(static_cast<std::mt19937::result_type>(QRandomGenerator::global()->generate()))); }
|
||||
return rng.localData();
|
||||
|
||||
@@ -17,11 +17,12 @@
|
||||
|
||||
namespace BlackMisc
|
||||
{
|
||||
static QThreadStorage<std::vector<const CJsonScope *>> g_stack;
|
||||
|
||||
//! \private
|
||||
auto &jsonStack() noexcept
|
||||
{
|
||||
static QThreadStorage<std::vector<const CJsonScope *>> stack;
|
||||
return stack.localData();
|
||||
return g_stack.localData();
|
||||
}
|
||||
|
||||
// pin vtables to this file
|
||||
|
||||
@@ -114,7 +114,7 @@ namespace BlackMisc
|
||||
static const CLogCategoryList &fromClass()
|
||||
{
|
||||
static_assert(sizeof(T) > 0, "T must be a complete type, not forward declared");
|
||||
static QThreadStorage<CLogCategoryList> list;
|
||||
static QThreadStorage<CLogCategoryList> list; //! \todo C++17: make list an inline static member variable template
|
||||
if (! list.hasLocalData())
|
||||
{
|
||||
list.localData().appendCategoriesFromMemberFunction(tag<T>(), THasGetLogCategories<T>());
|
||||
|
||||
Reference in New Issue
Block a user