Fix clang-tidy and clazy warnings

This commit is contained in:
Mat Sutcliffe
2021-08-27 16:21:41 +01:00
parent 2aeacf49a7
commit eb6b0ff289
122 changed files with 197 additions and 205 deletions

View File

@@ -651,7 +651,7 @@ namespace BlackMisc
CAirlineIcaoCode CAircraftModelList::getAirlineWithMaxCount() const
{
const QMap<CAirlineIcaoCode, int> ac = this->countPerAirlineIcao();
if (ac.size() < 1) { return {}; }
if (ac.isEmpty()) { return {}; }
if (ac.size() == 1) { return ac.firstKey(); }
const QList<int> values = ac.values();
const int max = *std::max_element(values.begin(), values.end());
@@ -1641,7 +1641,7 @@ namespace BlackMisc
return msgs;
}
CStatusMessageList CAircraftModelList::validateUncFiles(const QSet<QString> uncFiles) const
CStatusMessageList CAircraftModelList::validateUncFiles(const QSet<QString> &uncFiles) const
{
// check if UNC paths can be reached
CStatusMessageList msgs;