flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-04 16:56:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy and clazy warnings

Browse Source
This commit is contained in:
Mat Sutcliffe
2021-08-27 16:21:41 +01:00
parent 2aeacf49a7
commit eb6b0ff289
122 changed files with 197 additions and 205 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/blackmisc/valuecache.cpp
View File

@@ -254,7 +254,7 @@ namespace BlackMisc
void CValueCache::changeValues(const CValueCachePacket &values)
{
QMutexLocker lock(&m_mutex);
if (values.empty()) { return; }
if (values.isEmpty()) { return; }
m_elements.detach(); //! \fixme see http://doc.qt.io/qt-5/containers.html#implicit-sharing-iterator-problem
auto out = std::as_const(m_elements).lowerBound(values.cbegin().key());
auto end = std::as_const(m_elements).upperBound((values.cend() - 1).key());
@@ -284,7 +284,7 @@ namespace BlackMisc
void CValueCache::changeValuesFromRemote(const CValueCachePacket &values, const CIdentifier &originator)
{
QMutexLocker lock(&m_mutex);
if (values.empty()) { return; }
if (values.isEmpty()) { return; }
if (! values.valuesChanged())
{
if (values.isSaved()) { emit valuesSaveRequested(values); }
@@ -314,12 +314,12 @@ namespace BlackMisc
ratifiedChanges.insert(in.key(), in.value(), in.timestamp());
}
}
if (! ratifiedChanges.empty())
if (! ratifiedChanges.isEmpty())
{
if (ratifiedChanges.isSaved()) { emit valuesSaveRequested(ratifiedChanges); }
emit valuesChanged(ratifiedChanges, nullptr);
}
if (! ackedChanges.empty() && ackedChanges.isSaved()) { emit valuesSaveRequested(ackedChanges); }
if (! ackedChanges.isEmpty() && ackedChanges.isSaved()) { emit valuesSaveRequested(ackedChanges); }
}
QJsonObject CValueCache::saveToJson(const QString &keyPrefix) const
@@ -820,7 +820,7 @@ namespace BlackMisc
Q_ASSERT(m_batchMode >= 0);
m_batchMode--;
if (m_batchMode <= 0 && ! m_batchedValues.empty())
if (m_batchMode <= 0 && ! m_batchedValues.isEmpty())
{
qint64 timestamp = QDateTime::currentMSecsSinceEpoch();
forEachIntersection(m_elements, m_batchedValues, [timestamp](const QString &, const ElementPtr & element, CVariantMap::const_iterator it)