diff --git a/src/blackmisc/pq/pqstring.cpp b/src/blackmisc/pq/pqstring.cpp index 06bf67a51..b11cae6da 100644 --- a/src/blackmisc/pq/pqstring.cpp +++ b/src/blackmisc/pq/pqstring.cpp @@ -31,7 +31,7 @@ namespace BlackMisc { QString CPqString::convertToQString(bool /** i18n **/) const { - return this->m_string; + return m_string; } CVariant CPqString::parseToVariant(const QString &value, SeparatorMode mode) @@ -45,68 +45,68 @@ namespace BlackMisc if (vs.isEmpty()) { return v; } thread_local const QRegularExpression regex("([-+]?[0-9]*[\\.,]?[0-9]+)\\s*(\\D*)$"); - auto match = regex.match(value); + const auto match = regex.match(value); if (!match.hasMatch()) { return v; } // not a valid number QString unit = match.captured(2).trimmed(); - QString number = QString(value).replace(unit, ""); + const QString number = QString(value).replace(unit, ""); unit = unit.trimmed(); // trim after replace, not before if (unit.isEmpty() || number.isEmpty()) { return v; } bool success; - double numberD = parseNumber(number, success, mode); + const double numberD = parseNumber(number, success, mode); if (!success) {return v; } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CAcceleration pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CAcceleration pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CAngle pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CAngle pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CFrequency pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CFrequency pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CLength pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CLength pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CMass pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CMass pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CPressure pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CPressure pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CSpeed pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CSpeed pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CTime pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CTime pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } if (CMeasurementUnit::isValidUnitSymbol(unit)) { - CTemperature pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); + const CTemperature pq(numberD, CMeasurementUnit::unitFromSymbol(unit, false)); return CVariant::from(pq); } return v; @@ -133,6 +133,5 @@ namespace BlackMisc } return numberD; } - } // namespace } // namespace diff --git a/src/blackmisc/pq/pqstring.h b/src/blackmisc/pq/pqstring.h index 56a5c2f43..f00e50096 100644 --- a/src/blackmisc/pq/pqstring.h +++ b/src/blackmisc/pq/pqstring.h @@ -62,16 +62,14 @@ namespace BlackMisc //! Parse into concrete type template static PQ parse(const QString &value, SeparatorMode mode = SeparatorsCLocale) { - PQ null; - null.setNull(); - if (value.isEmpty()) {return null; } - if (value.contains("null", Qt::CaseInsensitive)) { return null; } + if (value.isEmpty()) {return PQ::null(); } + if (value.contains("null", Qt::CaseInsensitive)) { return PQ::null(); } const CVariant qv = parseToVariant(value, mode); if (!qv.isNull() && qv.canConvert()) { return qv.value(); } - return null; + return PQ::null(); } //! Locale aware parsing