[FS9] Fix double deletion of CFs9Host

CFs9Host was guarded by a QSharedPointer plus it had a QObject parent.

src/plugins/simulator/fs9/directplaypeer.cpp

@@ -30,7 +30,7 @@ namespace BlackSimPlugin
             return cats;
         }
 
-        CDirectPlayPeer::CDirectPlayPeer(QObject *parent, const CCallsign &callsign)
+        CDirectPlayPeer::CDirectPlayPeer(const CCallsign &callsign, QObject *parent)
             : QObject(parent),
               m_callsign(callsign),
               m_callbackWrapper(this, &CDirectPlayPeer::directPlayMessageHandler)

src/plugins/simulator/fs9/directplaypeer.h

@@ -13,7 +13,6 @@
 #include "hostnode.h"
 #include "callbackwrapper.h"
 #include "blackmisc/aviation/callsign.h"
-#include "blackmisc/worker.h"
 #include "blackmisc/logcategorylist.h"
 #include <QObject>
 #include <QList>
@@ -38,7 +37,7 @@ namespace BlackSimPlugin
 
         public:
             //! Constructor
-            CDirectPlayPeer(QObject *parent, const BlackMisc::Aviation::CCallsign &callsign);
+            CDirectPlayPeer(const BlackMisc::Aviation::CCallsign &callsign, QObject *parent = nullptr);
 
             //! Destructor
             virtual ~CDirectPlayPeer() override;

src/plugins/simulator/fs9/fs9client.cpp

@@ -35,7 +35,7 @@ namespace BlackSimPlugin
         CFs9Client::CFs9Client(const CSimulatedAircraft &remoteAircraft,
                                const CTime &updateInterval,
                                CInterpolationLogger *logger, ISimulator *simulator) :
-            CDirectPlayPeer(simulator, remoteAircraft.getCallsign()),
+            CDirectPlayPeer(remoteAircraft.getCallsign(), simulator),
             m_remoteAircraft(remoteAircraft),
             m_updateInterval(updateInterval),
             m_interpolator(remoteAircraft.getCallsign(), simulator, simulator, simulator->getRemoteAircraftProvider(), logger),

src/plugins/simulator/fs9/fs9host.cpp

@@ -24,8 +24,8 @@ namespace BlackSimPlugin
 {
     namespace Fs9
     {
-        CFs9Host::CFs9Host(QObject *owner) :
+        CFs9Host::CFs9Host(QObject *parent) :
-            CDirectPlayPeer(owner, sApp->swiftVersionString())
+            CDirectPlayPeer(sApp->swiftVersionString(), parent)
         {
             initDirectPlay();
             createHostAddress();

src/plugins/simulator/fs9/fs9host.h

@@ -31,7 +31,7 @@ namespace BlackSimPlugin
             };
 
             //! Constructor
-            CFs9Host(QObject *owner);
+            CFs9Host(QObject *parent = nullptr);
 
             //! Destructor
             virtual ~CFs9Host() override;

src/plugins/simulator/fs9/simulatorfs9.cpp

@@ -553,7 +553,7 @@ namespace BlackSimPlugin
 
         CSimulatorFs9Factory::CSimulatorFs9Factory(QObject *parent) :
             QObject(parent),
-            m_fs9Host(new CFs9Host(this), cleanupFs9Host),
+            m_fs9Host(new CFs9Host, cleanupFs9Host),
             m_lobbyClient(new CLobbyClient, cleanupLobbyClient)
         {
             registerMetadata();