Ref T275, IRemoteAircraftProvider::remoteAircraftParts cutoff time was never used so parameter was removed

This commit is contained in:
Klaus Basan
2018-06-13 18:24:20 +02:00
parent 978fe5eea2
commit fb93d26453
10 changed files with 32 additions and 40 deletions

View File

@@ -84,24 +84,17 @@ namespace BlackMisc
return m_situationsByCallsign[callsign].size();
}
CAircraftPartsList CRemoteAircraftProvider::remoteAircraftParts(const CCallsign &callsign, qint64 cutoffTimeValuesBefore) const
CAircraftPartsList CRemoteAircraftProvider::remoteAircraftParts(const CCallsign &callsign) const
{
static const CAircraftPartsList empty;
QReadLocker l(&m_lockParts);
if (!m_partsByCallsign.contains(callsign)) { return empty; }
if (cutoffTimeValuesBefore < 0)
{
return m_partsByCallsign[callsign];
}
else
{
return m_partsByCallsign[callsign].findBefore(cutoffTimeValuesBefore);
}
return m_partsByCallsign[callsign];
}
int CRemoteAircraftProvider::remoteAircraftPartsCount(const CCallsign &callsign, qint64 cutoffTimeValuesBefore) const
int CRemoteAircraftProvider::remoteAircraftPartsCount(const CCallsign &callsign) const
{
const int s = this->remoteAircraftParts(callsign, cutoffTimeValuesBefore).size();
const int s = this->remoteAircraftParts(callsign).size();
return s;
}
@@ -676,16 +669,16 @@ namespace BlackMisc
return this->provider()->remoteAircraftSituationChange(callsign);
}
CAircraftPartsList CRemoteAircraftAware::remoteAircraftParts(const CCallsign &callsign, qint64 cutoffTimeBefore) const
CAircraftPartsList CRemoteAircraftAware::remoteAircraftParts(const CCallsign &callsign) const
{
Q_ASSERT_X(this->provider(), Q_FUNC_INFO, "No object available");
return this->provider()->remoteAircraftParts(callsign, cutoffTimeBefore);
return this->provider()->remoteAircraftParts(callsign);
}
int CRemoteAircraftAware::remoteAircraftPartsCount(const CCallsign &callsign, qint64 cutoffTimeBefore) const
int CRemoteAircraftAware::remoteAircraftPartsCount(const CCallsign &callsign) const
{
Q_ASSERT_X(this->provider(), Q_FUNC_INFO, "No object available");
return this->provider()->remoteAircraftPartsCount(callsign, cutoffTimeBefore);
return this->provider()->remoteAircraftPartsCount(callsign);
}
CCallsignSet CRemoteAircraftAware::remoteAircraftSupportingParts() const
@@ -775,7 +768,7 @@ namespace BlackMisc
CAircraftParts IRemoteAircraftProvider::getLatestAircraftParts(const CCallsign &callsign) const
{
static const CAircraftParts empty;
const CAircraftPartsList parts = this->remoteAircraftParts(callsign, -1);
const CAircraftPartsList parts = this->remoteAircraftParts(callsign);
return parts.isEmpty() ? empty : parts.latestObject();
}

View File

@@ -95,11 +95,11 @@ namespace BlackMisc
//! All parts (per callsign, time history)
//! \remark latest parts first
//! \threadsafe
virtual Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign, qint64 cutoffTimeBefore = -1) const = 0;
virtual Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign) const = 0;
//! All parts (per callsign, time history)
//! \threadsafe
virtual int remoteAircraftPartsCount(const Aviation::CCallsign &callsign, qint64 cutoffTimeBefore = -1) const = 0;
virtual int remoteAircraftPartsCount(const Aviation::CCallsign &callsign) const = 0;
//! Get the change object for callsign
//! \threadsafe
@@ -246,8 +246,8 @@ namespace BlackMisc
virtual bool isVtolAircraft(const Aviation::CCallsign &callsign) const override;
virtual Aviation::CAircraftSituationList remoteAircraftSituations(const Aviation::CCallsign &callsign) const override;
virtual int remoteAircraftSituationsCount(const Aviation::CCallsign &callsign) const override;
virtual Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign, qint64 cutoffTimeValuesBefore = -1) const override;
virtual int remoteAircraftPartsCount(const Aviation::CCallsign &callsign, qint64 cutoffTimeValuesBefore = -1) const override;
virtual Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign) const override;
virtual int remoteAircraftPartsCount(const Aviation::CCallsign &callsign) const override;
virtual bool isRemoteAircraftSupportingParts(const Aviation::CCallsign &callsign) const override;
virtual int getRemoteAircraftSupportingPartsCount() const override;
virtual Aviation::CCallsignSet remoteAircraftSupportingParts() const override;
@@ -381,7 +381,7 @@ namespace BlackMisc
CSimulatedAircraftList m_aircraftInRange; //!< aircraft, thread safe access required
Aviation::CStatusMessageListPerCallsign m_reverseLookupMessages; //!< reverse lookup messages
Aviation::CStatusMessageListPerCallsign m_aircraftPartsHistory; //!< status messages for parts history
Aviation::CStatusMessageListPerCallsign m_aircraftPartsMessages; //!< status messages for parts history
Aviation::CTimestampPerCallsign m_situationsLastModified; //!< when situations last modified
Aviation::CTimestampPerCallsign m_partsLastModified; //!< when parts last modified
QHash<Aviation::CCallsign, PhysicalQuantities::CLength> m_testOffset;
@@ -432,10 +432,10 @@ namespace BlackMisc
int remoteAircraftSituationsCount(const Aviation::CCallsign &callsign) const;
//! \copydoc IRemoteAircraftProvider::remoteAircraftParts
Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign, qint64 cutoffTimeBefore = -1) const;
Aviation::CAircraftPartsList remoteAircraftParts(const Aviation::CCallsign &callsign) const;
//! \copydoc IRemoteAircraftProvider::remoteAircraftPartsCount
int remoteAircraftPartsCount(const Aviation::CCallsign &callsign, qint64 cutoffTimeBefore = -1) const;
int remoteAircraftPartsCount(const Aviation::CCallsign &callsign) const;
//! \copydoc IRemoteAircraftProvider::remoteAircraftSituationChange
Aviation::CAircraftSituationChange remoteAircraftSituationChange(const Aviation::CCallsign &callsign) const;