From fc540236441ab8e827ae6fe144841e8a2d87b849 Mon Sep 17 00:00:00 2001 From: Lars Toenning Date: Sat, 25 Oct 2025 17:08:05 +0200 Subject: [PATCH] refactor: Fix readability-redundant-member-init warning --- .clang-tidy | 1 + src/core/fsd/addatc.cpp | 2 -- src/core/fsd/addatc.h | 2 +- src/core/fsd/addpilot.h | 2 +- src/core/fsd/atcdataupdate.cpp | 2 -- src/core/fsd/atcdataupdate.h | 2 +- src/core/fsd/authchallenge.cpp | 2 -- src/core/fsd/authchallenge.h | 2 +- src/core/fsd/authresponse.cpp | 2 -- src/core/fsd/authresponse.h | 2 +- src/core/fsd/clientidentification.cpp | 2 -- src/core/fsd/clientidentification.h | 2 +- src/core/fsd/clientquery.cpp | 2 -- src/core/fsd/clientquery.h | 2 +- src/core/fsd/deleteatc.cpp | 2 -- src/core/fsd/deleteatc.h | 2 +- src/core/fsd/deletepilot.cpp | 2 -- src/core/fsd/deletepilot.h | 2 +- src/core/fsd/fsdidentification.cpp | 2 -- src/core/fsd/fsdidentification.h | 2 +- src/core/fsd/interimpilotdataupdate.cpp | 2 -- src/core/fsd/interimpilotdataupdate.h | 2 +- src/core/fsd/killrequest.cpp | 2 -- src/core/fsd/killrequest.h | 2 +- src/core/fsd/pilotdataupdate.cpp | 2 -- src/core/fsd/pilotdataupdate.h | 2 +- src/core/fsd/ping.cpp | 2 -- src/core/fsd/ping.h | 2 +- src/core/fsd/planeinforequest.cpp | 2 -- src/core/fsd/planeinforequest.h | 2 +- src/core/fsd/planeinforequestfsinn.cpp | 2 -- src/core/fsd/planeinforequestfsinn.h | 2 +- src/core/fsd/planeinformation.cpp | 2 -- src/core/fsd/planeinformation.h | 2 +- src/core/fsd/planeinformationfsinn.cpp | 2 -- src/core/fsd/planeinformationfsinn.h | 2 +- src/core/fsd/pong.cpp | 2 -- src/core/fsd/pong.h | 2 +- src/core/fsd/rehost.cpp | 2 -- src/core/fsd/rehost.h | 2 +- src/core/fsd/textmessage.cpp | 2 -- src/core/fsd/textmessage.h | 2 +- src/core/fsd/visualpilotdataperiodic.cpp | 2 -- src/core/fsd/visualpilotdataperiodic.h | 2 +- src/core/fsd/visualpilotdatastopped.cpp | 2 -- src/core/fsd/visualpilotdatastopped.h | 2 +- src/core/fsd/visualpilotdatatoggle.cpp | 2 -- src/core/fsd/visualpilotdatatoggle.h | 2 +- src/core/fsd/visualpilotdataupdate.cpp | 2 -- src/core/fsd/visualpilotdataupdate.h | 2 +- src/core/simulator.cpp | 2 +- src/gui/components/simulatorcomponent.cpp | 3 +-- src/gui/components/usercomponent.cpp | 3 +-- src/misc/network/urllog.cpp | 5 +---- src/misc/simulation/remoteaircraftprovider.cpp | 4 +--- 55 files changed, 31 insertions(+), 85 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 6b2e383ad..57efd7d15 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -44,6 +44,7 @@ Checks: > modernize-use-using, readability-use-std-min-max, readability-use-anyofallof, + readability-redundant-member-init, CheckOptions: - key: readability-identifier-naming.ClassCase diff --git a/src/core/fsd/addatc.cpp b/src/core/fsd/addatc.cpp index b4bf6552a..42dde8d35 100644 --- a/src/core/fsd/addatc.cpp +++ b/src/core/fsd/addatc.cpp @@ -8,8 +8,6 @@ namespace swift::core::fsd { - AddAtc::AddAtc() : MessageBase() {} - AddAtc::AddAtc(const QString &callsign, const QString &realName, const QString &cid, const QString &password, AtcRating rating, int protocolRevision) : MessageBase(callsign, "SERVER"), m_cid(cid), m_password(password), m_rating(rating), diff --git a/src/core/fsd/addatc.h b/src/core/fsd/addatc.h index c1bb25b79..118c2a2a5 100644 --- a/src/core/fsd/addatc.h +++ b/src/core/fsd/addatc.h @@ -47,7 +47,7 @@ namespace swift::core::fsd QString realName() const { return m_realName; } private: - AddAtc(); + AddAtc() = default; QString m_cid; QString m_password; diff --git a/src/core/fsd/addpilot.h b/src/core/fsd/addpilot.h index 1957d1231..8c6ca58c5 100644 --- a/src/core/fsd/addpilot.h +++ b/src/core/fsd/addpilot.h @@ -50,7 +50,7 @@ namespace swift::core::fsd static QString pdu() { return "#AP"; } private: - AddPilot() : MessageBase() {} + AddPilot() = default; QString m_cid; QString m_password; diff --git a/src/core/fsd/atcdataupdate.cpp b/src/core/fsd/atcdataupdate.cpp index 7a482119b..b666ba137 100644 --- a/src/core/fsd/atcdataupdate.cpp +++ b/src/core/fsd/atcdataupdate.cpp @@ -11,8 +11,6 @@ using namespace swift::misc::network; namespace swift::core::fsd { - AtcDataUpdate::AtcDataUpdate() : MessageBase() {} - AtcDataUpdate::AtcDataUpdate(const QString &sender, int frequencykHz, CFacilityType facility, int visibleRange, AtcRating rating, double latitude, double longitude, int elevation) : MessageBase(sender, {}), m_frequencykHz(frequencykHz), m_facility(facility), m_visibleRange(visibleRange), diff --git a/src/core/fsd/atcdataupdate.h b/src/core/fsd/atcdataupdate.h index 023006f4f..637f5ec7f 100644 --- a/src/core/fsd/atcdataupdate.h +++ b/src/core/fsd/atcdataupdate.h @@ -46,7 +46,7 @@ namespace swift::core::fsd private: //! Ctor - AtcDataUpdate(); + AtcDataUpdate() = default; }; //! Equal to operator diff --git a/src/core/fsd/authchallenge.cpp b/src/core/fsd/authchallenge.cpp index a4d05d966..efbe4499e 100644 --- a/src/core/fsd/authchallenge.cpp +++ b/src/core/fsd/authchallenge.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - AuthChallenge::AuthChallenge() : MessageBase() {} - AuthChallenge::AuthChallenge(const QString &sender, const QString &target, const QString &challengeKey) : MessageBase(sender, target), m_challengeKey(challengeKey) {} diff --git a/src/core/fsd/authchallenge.h b/src/core/fsd/authchallenge.h index 460219ef6..4f13a38d2 100644 --- a/src/core/fsd/authchallenge.h +++ b/src/core/fsd/authchallenge.h @@ -30,7 +30,7 @@ namespace swift::core::fsd private: //! Ctor - AuthChallenge(); + AuthChallenge() = default; }; //! Equal to operator diff --git a/src/core/fsd/authresponse.cpp b/src/core/fsd/authresponse.cpp index e1859c961..94895c50a 100644 --- a/src/core/fsd/authresponse.cpp +++ b/src/core/fsd/authresponse.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - AuthResponse::AuthResponse() : MessageBase() {} - AuthResponse::AuthResponse(const QString &sender, const QString &receiver, const QString &response) : MessageBase(sender, receiver), m_response(response) {} diff --git a/src/core/fsd/authresponse.h b/src/core/fsd/authresponse.h index 60b2f8523..fe702e806 100644 --- a/src/core/fsd/authresponse.h +++ b/src/core/fsd/authresponse.h @@ -30,7 +30,7 @@ namespace swift::core::fsd QString m_response; //!< response private: - AuthResponse(); + AuthResponse() = default; }; //! Equal to operator diff --git a/src/core/fsd/clientidentification.cpp b/src/core/fsd/clientidentification.cpp index e17c7aa7c..81ecc899f 100644 --- a/src/core/fsd/clientidentification.cpp +++ b/src/core/fsd/clientidentification.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - ClientIdentification::ClientIdentification() : MessageBase() {} - ClientIdentification::ClientIdentification(const QString &sender, quint16 clientId, const QString &clientName, int clientVersionMajor, int clientVersionMinor, const QString &userCid, const QString &sysUid, const QString &initialChallenge) diff --git a/src/core/fsd/clientidentification.h b/src/core/fsd/clientidentification.h index 21398a1e1..4fcf32edc 100644 --- a/src/core/fsd/clientidentification.h +++ b/src/core/fsd/clientidentification.h @@ -43,7 +43,7 @@ namespace swift::core::fsd //! @} private: - ClientIdentification(); + ClientIdentification() = default; }; //! Equal to operator diff --git a/src/core/fsd/clientquery.cpp b/src/core/fsd/clientquery.cpp index c8b412d5e..1cd6d333f 100644 --- a/src/core/fsd/clientquery.cpp +++ b/src/core/fsd/clientquery.cpp @@ -8,8 +8,6 @@ namespace swift::core::fsd { - ClientQuery::ClientQuery() : MessageBase() {} - ClientQuery::ClientQuery(const QString &sender, const QString &clientToBeQueried, ClientQueryType queryType, const QStringList &queryData) : MessageBase(sender, clientToBeQueried), m_queryType(queryType), m_queryData(queryData) diff --git a/src/core/fsd/clientquery.h b/src/core/fsd/clientquery.h index c83be9d76..a021955b0 100644 --- a/src/core/fsd/clientquery.h +++ b/src/core/fsd/clientquery.h @@ -40,7 +40,7 @@ namespace swift::core::fsd //! @} private: - ClientQuery(); + ClientQuery() = default; }; //! Equal to operator diff --git a/src/core/fsd/deleteatc.cpp b/src/core/fsd/deleteatc.cpp index 2577b03da..4b9c40b8e 100644 --- a/src/core/fsd/deleteatc.cpp +++ b/src/core/fsd/deleteatc.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - DeleteAtc::DeleteAtc() : MessageBase() {} - DeleteAtc::DeleteAtc(const QString &sender, const QString &cid) : MessageBase(sender), m_cid(cid) {} QStringList DeleteAtc::toTokens() const diff --git a/src/core/fsd/deleteatc.h b/src/core/fsd/deleteatc.h index 3ac1cc094..98148110d 100644 --- a/src/core/fsd/deleteatc.h +++ b/src/core/fsd/deleteatc.h @@ -29,7 +29,7 @@ namespace swift::core::fsd QString m_cid; //!< id private: - DeleteAtc(); + DeleteAtc() = default; }; //! Equal to operator diff --git a/src/core/fsd/deletepilot.cpp b/src/core/fsd/deletepilot.cpp index 8995ed791..f6810c8b4 100644 --- a/src/core/fsd/deletepilot.cpp +++ b/src/core/fsd/deletepilot.cpp @@ -9,8 +9,6 @@ using namespace swift::misc; namespace swift::core::fsd { - DeletePilot::DeletePilot() : MessageBase() {} - DeletePilot::DeletePilot(const QString &callsign, const QString &id) : MessageBase(callsign), m_cid(id) {} QStringList DeletePilot::toTokens() const diff --git a/src/core/fsd/deletepilot.h b/src/core/fsd/deletepilot.h index 736796938..1c666818f 100644 --- a/src/core/fsd/deletepilot.h +++ b/src/core/fsd/deletepilot.h @@ -31,7 +31,7 @@ namespace swift::core::fsd private: //! Ctor - DeletePilot(); + DeletePilot() = default; }; //! Equal to operator diff --git a/src/core/fsd/fsdidentification.cpp b/src/core/fsd/fsdidentification.cpp index 2b58b38a4..4e273c704 100644 --- a/src/core/fsd/fsdidentification.cpp +++ b/src/core/fsd/fsdidentification.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - FSDIdentification::FSDIdentification() : MessageBase() {} - FSDIdentification::FSDIdentification(const QString &callsign, const QString &receiver, const QString &serverVersion, const QString &initialChallenge) : MessageBase(callsign, receiver), m_serverVersion(serverVersion), m_initialChallenge(initialChallenge) diff --git a/src/core/fsd/fsdidentification.h b/src/core/fsd/fsdidentification.h index 277ab090d..f74b96820 100644 --- a/src/core/fsd/fsdidentification.h +++ b/src/core/fsd/fsdidentification.h @@ -34,7 +34,7 @@ namespace swift::core::fsd //! @} private: - FSDIdentification(); + FSDIdentification() = default; }; } // namespace swift::core::fsd diff --git a/src/core/fsd/interimpilotdataupdate.cpp b/src/core/fsd/interimpilotdataupdate.cpp index a9ace13cc..2f704ed32 100644 --- a/src/core/fsd/interimpilotdataupdate.cpp +++ b/src/core/fsd/interimpilotdataupdate.cpp @@ -8,8 +8,6 @@ namespace swift::core::fsd { - InterimPilotDataUpdate::InterimPilotDataUpdate() : MessageBase() {} - InterimPilotDataUpdate::InterimPilotDataUpdate(const QString &sender, const QString &receiver, double latitude, double longitude, int altitudeTrue, int groundSpeed, double pitch, double bank, double heading, bool onGround) diff --git a/src/core/fsd/interimpilotdataupdate.h b/src/core/fsd/interimpilotdataupdate.h index 42f5900d5..411aa0299 100644 --- a/src/core/fsd/interimpilotdataupdate.h +++ b/src/core/fsd/interimpilotdataupdate.h @@ -42,7 +42,7 @@ namespace swift::core::fsd //! @} private: - InterimPilotDataUpdate(); + InterimPilotDataUpdate() = default; }; //! Equal to operator diff --git a/src/core/fsd/killrequest.cpp b/src/core/fsd/killrequest.cpp index ad05a9ff1..fbadf0504 100644 --- a/src/core/fsd/killrequest.cpp +++ b/src/core/fsd/killrequest.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - KillRequest::KillRequest() : MessageBase() {} - KillRequest::KillRequest(const QString &callsign, const QString &receiver, const QString &reason) : MessageBase(callsign, receiver), m_reason(reason) {} diff --git a/src/core/fsd/killrequest.h b/src/core/fsd/killrequest.h index d54d7b04d..57be64f78 100644 --- a/src/core/fsd/killrequest.h +++ b/src/core/fsd/killrequest.h @@ -30,7 +30,7 @@ namespace swift::core::fsd QString m_reason; //!< reason for kill request/kicked private: - KillRequest(); + KillRequest() = default; }; //! Equal to operator diff --git a/src/core/fsd/pilotdataupdate.cpp b/src/core/fsd/pilotdataupdate.cpp index 51dd63c61..905dcf4a8 100644 --- a/src/core/fsd/pilotdataupdate.cpp +++ b/src/core/fsd/pilotdataupdate.cpp @@ -12,8 +12,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - PilotDataUpdate::PilotDataUpdate() : MessageBase() {} - PilotDataUpdate::PilotDataUpdate(CTransponder::TransponderMode transponderMode, const QString &sender, int transponderCode, PilotRating rating, double latitude, double longitude, int altitudeTrue, int altitudePressure, int groundSpeed, double pitch, double bank, diff --git a/src/core/fsd/pilotdataupdate.h b/src/core/fsd/pilotdataupdate.h index 5b811831a..ea53f4d5e 100644 --- a/src/core/fsd/pilotdataupdate.h +++ b/src/core/fsd/pilotdataupdate.h @@ -49,7 +49,7 @@ namespace swift::core::fsd //! @} private: - PilotDataUpdate(); + PilotDataUpdate() = default; }; //! Equal to operator diff --git a/src/core/fsd/ping.cpp b/src/core/fsd/ping.cpp index c3c2f776f..49774ded4 100644 --- a/src/core/fsd/ping.cpp +++ b/src/core/fsd/ping.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - Ping::Ping() : MessageBase() {} - Ping::Ping(const QString &sender, const QString &receiver, const QString ×tamp) : MessageBase(sender, receiver), m_timestamp(timestamp) {} diff --git a/src/core/fsd/ping.h b/src/core/fsd/ping.h index 6d3d19023..ba5270b63 100644 --- a/src/core/fsd/ping.h +++ b/src/core/fsd/ping.h @@ -29,7 +29,7 @@ namespace swift::core::fsd QString m_timestamp; //!< timestamp private: - Ping(); + Ping() = default; }; //! Equal to operator diff --git a/src/core/fsd/planeinforequest.cpp b/src/core/fsd/planeinforequest.cpp index ea2adbb1c..adc0d29ae 100644 --- a/src/core/fsd/planeinforequest.cpp +++ b/src/core/fsd/planeinforequest.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - PlaneInfoRequest::PlaneInfoRequest() : MessageBase() {} - PlaneInfoRequest::PlaneInfoRequest(const QString &sender, const QString &receiver) : MessageBase(sender, receiver) {} diff --git a/src/core/fsd/planeinforequest.h b/src/core/fsd/planeinforequest.h index 3693ec753..a4c624cfe 100644 --- a/src/core/fsd/planeinforequest.h +++ b/src/core/fsd/planeinforequest.h @@ -28,7 +28,7 @@ namespace swift::core::fsd static QString pdu() { return QStringLiteral("#SB"); } private: - PlaneInfoRequest(); + PlaneInfoRequest() = default; }; //! Equal to operator diff --git a/src/core/fsd/planeinforequestfsinn.cpp b/src/core/fsd/planeinforequestfsinn.cpp index 8d07f982e..e1d69ccac 100644 --- a/src/core/fsd/planeinforequestfsinn.cpp +++ b/src/core/fsd/planeinforequestfsinn.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - PlaneInfoRequestFsinn::PlaneInfoRequestFsinn() : MessageBase() {} - PlaneInfoRequestFsinn::PlaneInfoRequestFsinn(const QString &sender, const QString &receiver, const QString &airlineIcao, const QString &aircraftIcao, const QString &aircraftIcaoCombinedType, diff --git a/src/core/fsd/planeinforequestfsinn.h b/src/core/fsd/planeinforequestfsinn.h index 014bfcad2..bee865160 100644 --- a/src/core/fsd/planeinforequestfsinn.h +++ b/src/core/fsd/planeinforequestfsinn.h @@ -37,7 +37,7 @@ namespace swift::core::fsd //! @} private: - PlaneInfoRequestFsinn(); + PlaneInfoRequestFsinn() = default; }; //! Equal to operator diff --git a/src/core/fsd/planeinformation.cpp b/src/core/fsd/planeinformation.cpp index 0856324ec..c296bb987 100644 --- a/src/core/fsd/planeinformation.cpp +++ b/src/core/fsd/planeinformation.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - PlaneInformation::PlaneInformation() : MessageBase() {} - PlaneInformation::PlaneInformation(const QString &sender, const QString &receiver, const QString &aircraft, const QString &airline = QString(), const QString &livery = QString()) : MessageBase(sender, receiver), m_aircraft(aircraft), m_airline(airline), m_livery(livery) diff --git a/src/core/fsd/planeinformation.h b/src/core/fsd/planeinformation.h index 39d461135..45d024a32 100644 --- a/src/core/fsd/planeinformation.h +++ b/src/core/fsd/planeinformation.h @@ -36,7 +36,7 @@ namespace swift::core::fsd //! @} private: - PlaneInformation(); + PlaneInformation() = default; }; //! Equal to operator diff --git a/src/core/fsd/planeinformationfsinn.cpp b/src/core/fsd/planeinformationfsinn.cpp index a618cc007..1bcf87f6c 100644 --- a/src/core/fsd/planeinformationfsinn.cpp +++ b/src/core/fsd/planeinformationfsinn.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - PlaneInformationFsinn::PlaneInformationFsinn() : MessageBase() {} - PlaneInformationFsinn::PlaneInformationFsinn(const QString &sender, const QString &receiver, const QString &airlineIcao, const QString &aircraftIcao, const QString &aircraftIcaoCombinedType, diff --git a/src/core/fsd/planeinformationfsinn.h b/src/core/fsd/planeinformationfsinn.h index 51d356464..955a36fe6 100644 --- a/src/core/fsd/planeinformationfsinn.h +++ b/src/core/fsd/planeinformationfsinn.h @@ -37,7 +37,7 @@ namespace swift::core::fsd //! @} private: - PlaneInformationFsinn(); + PlaneInformationFsinn() = default; }; //! Equal to operator diff --git a/src/core/fsd/pong.cpp b/src/core/fsd/pong.cpp index 1e1ef6a9c..5c5730579 100644 --- a/src/core/fsd/pong.cpp +++ b/src/core/fsd/pong.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - Pong::Pong() : MessageBase() {} - Pong::Pong(const QString &sender, const QString &receiver, const QString ×tamp) : MessageBase(sender, receiver), m_timestamp(timestamp) {} diff --git a/src/core/fsd/pong.h b/src/core/fsd/pong.h index 9ad28b17b..a3314108f 100644 --- a/src/core/fsd/pong.h +++ b/src/core/fsd/pong.h @@ -29,7 +29,7 @@ namespace swift::core::fsd QString m_timestamp; //!< timestamp private: - Pong(); + Pong() = default; }; //! Equal to operator diff --git a/src/core/fsd/rehost.cpp b/src/core/fsd/rehost.cpp index e5bd207fb..c30609232 100644 --- a/src/core/fsd/rehost.cpp +++ b/src/core/fsd/rehost.cpp @@ -12,8 +12,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - Rehost::Rehost() : MessageBase() {} - Rehost::Rehost(const QString &sender, const QString &hostname) : MessageBase(sender, {}), m_hostname(hostname) {} QStringList Rehost::toTokens() const { return { m_sender, m_hostname }; } diff --git a/src/core/fsd/rehost.h b/src/core/fsd/rehost.h index 15db228c6..ab756d3c3 100644 --- a/src/core/fsd/rehost.h +++ b/src/core/fsd/rehost.h @@ -33,7 +33,7 @@ namespace swift::core::fsd //! @} private: - Rehost(); + Rehost() = default; }; //! Equal to operator diff --git a/src/core/fsd/textmessage.cpp b/src/core/fsd/textmessage.cpp index c5da36a5a..190ad605a 100644 --- a/src/core/fsd/textmessage.cpp +++ b/src/core/fsd/textmessage.cpp @@ -7,8 +7,6 @@ namespace swift::core::fsd { - TextMessage::TextMessage() : MessageBase() {} - TextMessage::TextMessage(const QString &sender, const QString &receiver, const QString &message) : MessageBase(sender, receiver), m_message(message) { diff --git a/src/core/fsd/textmessage.h b/src/core/fsd/textmessage.h index e98fde22e..a1448ac83 100644 --- a/src/core/fsd/textmessage.h +++ b/src/core/fsd/textmessage.h @@ -42,7 +42,7 @@ namespace swift::core::fsd QVector m_frequencies; //!< frequencies in case of radio message. private: - TextMessage(); + TextMessage() = default; }; } // namespace swift::core::fsd diff --git a/src/core/fsd/visualpilotdataperiodic.cpp b/src/core/fsd/visualpilotdataperiodic.cpp index cb1c8b4f3..ad5b686c7 100644 --- a/src/core/fsd/visualpilotdataperiodic.cpp +++ b/src/core/fsd/visualpilotdataperiodic.cpp @@ -14,8 +14,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - VisualPilotDataPeriodic::VisualPilotDataPeriodic() : MessageBase() {} - VisualPilotDataPeriodic::VisualPilotDataPeriodic(const QString &sender, double latitude, double longitude, double altitudeTrue, double heightAgl, double pitch, double bank, double heading, double xVelocity, double yVelocity, diff --git a/src/core/fsd/visualpilotdataperiodic.h b/src/core/fsd/visualpilotdataperiodic.h index 56a5c3450..d7b4476df 100644 --- a/src/core/fsd/visualpilotdataperiodic.h +++ b/src/core/fsd/visualpilotdataperiodic.h @@ -54,7 +54,7 @@ namespace swift::core::fsd //! @} private: - VisualPilotDataPeriodic(); + VisualPilotDataPeriodic() = default; }; //! Equal to operator diff --git a/src/core/fsd/visualpilotdatastopped.cpp b/src/core/fsd/visualpilotdatastopped.cpp index 9fb0a7d94..5ef5597b5 100644 --- a/src/core/fsd/visualpilotdatastopped.cpp +++ b/src/core/fsd/visualpilotdatastopped.cpp @@ -14,8 +14,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - VisualPilotDataStopped::VisualPilotDataStopped() : MessageBase() {} - VisualPilotDataStopped::VisualPilotDataStopped(const QString &sender, double latitude, double longitude, double altitudeTrue, double heightAgl, double pitch, double bank, double heading, double noseGearAngle) diff --git a/src/core/fsd/visualpilotdatastopped.h b/src/core/fsd/visualpilotdatastopped.h index 525a67bc5..0bc3dc520 100644 --- a/src/core/fsd/visualpilotdatastopped.h +++ b/src/core/fsd/visualpilotdatastopped.h @@ -46,7 +46,7 @@ namespace swift::core::fsd //! @} private: - VisualPilotDataStopped(); + VisualPilotDataStopped() = default; }; //! Equal to operator diff --git a/src/core/fsd/visualpilotdatatoggle.cpp b/src/core/fsd/visualpilotdatatoggle.cpp index 88ee70ba4..4b5a2019c 100644 --- a/src/core/fsd/visualpilotdatatoggle.cpp +++ b/src/core/fsd/visualpilotdatatoggle.cpp @@ -13,8 +13,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - VisualPilotDataToggle::VisualPilotDataToggle() : MessageBase() {} - VisualPilotDataToggle::VisualPilotDataToggle(const QString &sender, const QString &client, bool active) : MessageBase(sender, {}), m_client(client), m_active(active) {} diff --git a/src/core/fsd/visualpilotdatatoggle.h b/src/core/fsd/visualpilotdatatoggle.h index 059437d79..db17b49b5 100644 --- a/src/core/fsd/visualpilotdatatoggle.h +++ b/src/core/fsd/visualpilotdatatoggle.h @@ -34,7 +34,7 @@ namespace swift::core::fsd //! @} private: - VisualPilotDataToggle(); + VisualPilotDataToggle() = default; }; //! Equal to operator diff --git a/src/core/fsd/visualpilotdataupdate.cpp b/src/core/fsd/visualpilotdataupdate.cpp index 1755f4210..ec5e45058 100644 --- a/src/core/fsd/visualpilotdataupdate.cpp +++ b/src/core/fsd/visualpilotdataupdate.cpp @@ -15,8 +15,6 @@ using namespace swift::misc::aviation; namespace swift::core::fsd { - VisualPilotDataUpdate::VisualPilotDataUpdate() : MessageBase() {} - VisualPilotDataUpdate::VisualPilotDataUpdate(const QString &sender, double latitude, double longitude, double altitudeTrue, double heightAgl, double pitch, double bank, double heading, double xVelocity, double yVelocity, double zVelocity, diff --git a/src/core/fsd/visualpilotdataupdate.h b/src/core/fsd/visualpilotdataupdate.h index 390103a0e..401577642 100644 --- a/src/core/fsd/visualpilotdataupdate.h +++ b/src/core/fsd/visualpilotdataupdate.h @@ -58,7 +58,7 @@ namespace swift::core::fsd //! @} // private: // not private: used in CFSDClient::handleVisualPilotDataUpdate - VisualPilotDataUpdate(); + VisualPilotDataUpdate() = default; }; //! Equal to operator diff --git a/src/core/simulator.cpp b/src/core/simulator.cpp index 830477929..a65be0964 100644 --- a/src/core/simulator.cpp +++ b/src/core/simulator.cpp @@ -1232,7 +1232,7 @@ namespace swift::core } } - ISimulatorListener::ISimulatorListener(const CSimulatorPluginInfo &info) : QObject(), m_info(info) + ISimulatorListener::ISimulatorListener(const CSimulatorPluginInfo &info) : m_info(info) { this->setObjectName("ISimulatorListener:" + info.toQString()); diff --git a/src/gui/components/simulatorcomponent.cpp b/src/gui/components/simulatorcomponent.cpp index 7a38bc8e5..047495f37 100644 --- a/src/gui/components/simulatorcomponent.cpp +++ b/src/gui/components/simulatorcomponent.cpp @@ -39,8 +39,7 @@ namespace swift::gui::components return cats; } - CSimulatorComponent::CSimulatorComponent(QWidget *parent) - : QTabWidget(parent), CEnableForDockWidgetInfoArea(), ui(new Ui::CSimulatorComponent) + CSimulatorComponent::CSimulatorComponent(QWidget *parent) : QTabWidget(parent), ui(new Ui::CSimulatorComponent) { Q_ASSERT_X(sGui, Q_FUNC_INFO, "Need sGui"); diff --git a/src/gui/components/usercomponent.cpp b/src/gui/components/usercomponent.cpp index 612cf329e..f2cd2030b 100644 --- a/src/gui/components/usercomponent.cpp +++ b/src/gui/components/usercomponent.cpp @@ -25,8 +25,7 @@ using namespace swift::core::context; namespace swift::gui::components { - CUserComponent::CUserComponent(QWidget *parent) - : QTabWidget(parent), CEnableForDockWidgetInfoArea(), ui(new Ui::CUserComponent) + CUserComponent::CUserComponent(QWidget *parent) : QTabWidget(parent), ui(new Ui::CUserComponent) { ui->setupUi(this); this->setCurrentIndex(0); diff --git a/src/misc/network/urllog.cpp b/src/misc/network/urllog.cpp index 04ee8a3e8..72dc8422f 100644 --- a/src/misc/network/urllog.cpp +++ b/src/misc/network/urllog.cpp @@ -16,10 +16,7 @@ SWIFT_DEFINE_VALUEOBJECT_MIXINS(swift::misc::network, CUrlLog) namespace swift::misc::network { - CUrlLog::CUrlLog(const CUrl &url) : ITimestampBased(), m_id(uniqueId()), m_url(url) - { - ITimestampBased::setCurrentUtcTime(); - } + CUrlLog::CUrlLog(const CUrl &url) : m_id(uniqueId()), m_url(url) { ITimestampBased::setCurrentUtcTime(); } void CUrlLog::setResponseTimestampToNow() { diff --git a/src/misc/simulation/remoteaircraftprovider.cpp b/src/misc/simulation/remoteaircraftprovider.cpp index b3caf8e00..7b12cb0b9 100644 --- a/src/misc/simulation/remoteaircraftprovider.cpp +++ b/src/misc/simulation/remoteaircraftprovider.cpp @@ -24,9 +24,7 @@ namespace swift::misc::simulation return cats; } - CRemoteAircraftProvider::CRemoteAircraftProvider(QObject *parent) - : QObject(parent), IRemoteAircraftProvider(), CIdentifiable(this) - {} + CRemoteAircraftProvider::CRemoteAircraftProvider(QObject *parent) : QObject(parent), CIdentifiable(this) {} CSimulatedAircraftList CRemoteAircraftProvider::getAircraftInRange() const {