The name was not set at all and was falling back to the fullname being swift.
Instead set it explicitly to fullname including version and architecture.
The productDisplayIcon is evaluated at installer runtime and needs to be
set to a installed icon path.
The installer icon itself was to big (> 100 kb) and got unnecessary sizes
removed.
ref T344
Summary:
- Changed the name in all build artifacts
- Everywhere in C++
Reviewers: #swift_pilot_client, kbasan
Reviewed By: #swift_pilot_client, kbasan
Subscribers: jenkins
Maniphest Tasks: T205
Differential Revision: https://dev.swift-project.org/D69
Summary:
There were still many TODO's in installbuilder project file. This change replaces them with path to swift icons.
Depends on D58
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Differential Revision: https://dev.swift-project.org/D59
Summary:
Apple broke the hdiutil on MacOS 10.13. If one passes multiple -srcfolder
arguments, it dead locks with 100 % CPU forever. Since there is no way to
tell Bitrock to use only one -srcfolder argument, we have to go the
advanced way and create the disk image file manually. This also allows
us to customize it more in the future.
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Maniphest Tasks: T181
Differential Revision: https://dev.swift-project.org/D58
DBus session needs to be started from a central place. On Mac OS, the
recommended solution is launchd service since all dbus clients will query
launchd for the session address first. All other solutions would be hacky.
With this script, launchd will start dbus-daemon on demand and provide
the enviromental variable DBUS_LAUNCHD_SESSION_BUS_SOCKET.
We put this into the user launch agents folder to make it a user session.
ref T170
Summary:
Disabling happens in two steps. The binary was created as dependent target
of 'make create_installer'. This step is now skipped.
The second step is to remove it from the installbuilder project
configuration.
Disabling only so far to easily get it back if needed.
ref T124
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Maniphest Tasks: T124
Differential Revision: https://dev.swift-project.org/D46
Summary:
After installation, swiftlauncher is executed in wizard mode. However, installer
kept running in the background until the launcher was closed. Instead,
run swift in background which allows the installer to quit.
Reviewers: kbasan, msutcliffe
Reviewed By: msutcliffe
Differential Revision: https://dev.swift-project.org/D19
Summary:
The file machine-id was missing on target machines and needs
to be created during installation.
Reviewers: kbasan, msutcliffe
Reviewed By: msutcliffe
Subscribers: jenkins
Tags: #swift_pilot_client
Differential Revision: https://dev.swift-project.org/D17
