Commit Graph

689 Commits

Author SHA1 Message Date
Mathew Sutcliffe
f9ae3efaa3 T37 Avoid division by zero in case time offset is zero. 2017-09-24 19:52:49 +01:00
Mathew Sutcliffe
aaeb2e8ceb T37 Fixed wrong parameter names. 2017-09-24 19:52:44 +01:00
Mathew Sutcliffe
05c0d046aa Removed outdated todos. 2017-09-24 19:52:37 +01:00
Klaus Basan
3f924209f1 As a follow up of review T111, changed "void static" to "static void" for consistency. 2017-09-24 19:52:31 +01:00
Klaus Basan
fe3368e1f4 Ref T117, formatting 2017-09-24 19:52:15 +01:00
Klaus Basan
9903d518b0 Ref T117, utility functions
* detect equal models (equal in sense of "equal for publishing", not ==)
* severity functions for message list
2017-09-24 19:52:14 +01:00
Klaus Basan
0117558ea7 Formatting 2017-09-24 19:52:04 +01:00
Klaus Basan
7cc723c7c3 Ref T111, in provider allow to set cockpit by simulated aircraft 2017-09-24 19:51:58 +01:00
Klaus Basan
ea6cf20587 Ref T111, allow to set cockpit by passing another simulated aircraft 2017-09-24 19:51:56 +01:00
Klaus Basan
1387573e5b Ref T112, moved simulator settings in subdir/settings namespace 2017-09-24 19:51:46 +01:00
Klaus Basan
b70fb70d60 Ref T111, renamed dummy driver to CSimulatorEmulated 2017-09-24 19:51:43 +01:00
Klaus Basan
c36c3a4a05 Ref T111, set a single simulator as proposed by RW 2017-09-24 19:51:28 +01:00
Klaus Basan
4a9ab8c3d7 Ref T120, removed virtual dtor for
* CDictionary
* CAircraftCfgEntriesList
2017-09-24 19:51:23 +01:00
Klaus Basan
2b0241a8a7 Ref T111, utility function setEnabled 2017-09-24 19:51:22 +01:00
Klaus Basan
384c186fce Ref T111, removed as requested in review by MS 2017-09-24 19:51:19 +01:00
Klaus Basan
37ef181e13 Ref T113, COwnAircraftAware functions not virtual 2017-09-24 19:51:18 +01:00
Klaus Basan
7d88a64914 Ref T111, settings value object for swift pseudo driver 2017-09-24 19:51:07 +01:00
Klaus Basan
b423a62626 Ref T111, access to own aircraft`s situation 2017-09-24 19:51:06 +01:00
Klaus Basan
b1295cd457 Ref T111, added utility functions used for swift plugin (dummy driver)
* new reader functions
* plugin info
2017-09-24 19:51:04 +01:00
Klaus Basan
03a551d016 Ref T109, new utility functions for reverse lookup 2017-09-24 19:50:58 +01:00
Klaus Basan
551d9326fe Ref T109, make sure liveries and ICAO are compared correctly
* isDbEqual function
* used in getXXDifference functions
2017-09-24 19:50:55 +01:00
Klaus Basan
94c9886c35 Based on discussion around T107 and slack
* Use CJsonScope scope("MetaData") for stacktrace
* added Q_UNUSED(scope) to avoid QtC warnings
2017-09-24 19:50:37 +01:00
Klaus Basan
0e3a06c24e Ref T107, some minor fixes while investigating T107 2017-09-24 19:50:20 +01:00
Klaus Basan
a9198e4f13 Ref T103, Unified naming of directory functions
* some started with get/some not (removed get, get is normally used for our getters)
* some used swift, getSwiftXZY dir (removed swift)
* used full word "directory", not dir/directory mixed
2017-09-24 19:49:53 +01:00
Klaus Basan
debd9c802f Ref T103, moved directory functions from CBuildConfig to CDirectoryUtils
getApplicationDir renamed to getBinDir() as it works different on MacOs
see https://dev.swift-project.org/w/dev/swiftpc/dirstructure/
2017-09-24 19:49:51 +01:00
Klaus Basan
ec844fd438 Ref T27, made isAircraftInRange context and provider function
Based on clang warnings and RW's comment now pure virtual and context and provider function
2017-09-24 19:49:19 +01:00
Klaus Basan
d96a9a9fa2 Improved update missing parts 2017-09-24 19:49:02 +01:00
Klaus Basan
8cf79e4ddb Fixed minor isEmpty() bug 2017-06-27 20:50:34 +02:00
Klaus Basan
417496024e Ref T26, Ref T27, added utility function in remote aircraft provider 2017-06-27 20:50:33 +02:00
Klaus Basan
0c336952d2 Ref T26, Ref T27, utility functions in "value object" classes 2017-06-27 20:50:31 +02:00
Klaus Basan
1956a27b19 Formatting 2017-06-27 20:50:29 +02:00
Klaus Basan
6d26c96569 Ref T27, preparation for refactoring, turned private slots into normal member functions
* Motivation: slots no longer required, and in the driver the (small) slot overhead might matter
* renamed some members to better reflect future use
* timer intervals as constexpr
* fixed some typos and comments
2017-06-27 20:50:26 +02:00
Mathew Sutcliffe
bc80fd3bd5 [feature][XPlane] Set own aircraft model string when own aircraft changes.
Summary:
Refactored parts of CAircraftModelLoaderXPlane::parseFlyableAirplanes into static method extractAcfProperties that can be called by xswiftbus.

Used extractAcfProperties in xswiftbus to provide the model string to the driver. Implemented CSimulatorXPlane::ps_emitOwnAircraftModelChanged.

Implements T74.

Reviewers: rwinklmeier

Reviewed By: rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D23
2017-05-14 17:21:39 +01:00
Klaus Basan
a4100d7efa Ref T77, tooltip for models (HTML Summary) 2017-05-09 19:13:54 +02:00
Klaus Basan
afbb87298f Ref T77, prefix for getDbKeyAsStringInParentheses 2017-05-09 19:13:53 +02:00
Klaus Basan
5558cee4d8 Ref T67, utility functions for simulator info/model list 2017-05-09 19:13:45 +02:00
Klaus Basan
92472e78a6 Ref T58, consolidation fixes
* override simulator, because values can be removed
* DB simulator has priority
2017-05-09 19:13:42 +02:00
Mathew Sutcliffe
183d3f58e7 X-Plane model loader: fixed malformed model strings with spurious multiple liveries.
Each livery was being appended to the model string of the previous livery model.
Reported by Alex Beavil.
2017-05-07 21:52:14 +01:00
Mathew Sutcliffe
b1e57e28d0 Fixed QVector out-of-bounds assert in X-Plane model loader. 2017-05-06 20:22:46 +01:00
Klaus Basan
5b3097a2b0 Ref T28, description for cache 2017-05-05 23:08:18 +01:00
Klaus Basan
c3ed0bc394 Ref T28, removed areModelFilesUpdated and info if loading was from cache
* removed CacheUntilNewer
* did not really work and had some problems
* cache timestamp not really a good value to compare with
* too slow with remote file
2017-05-05 23:08:04 +01:00
Klaus Basan
4d156ad8fc Ref T28, description for caches 2017-05-05 23:07:51 +01:00
Mathew Sutcliffe
816f3bd48e New X-Plane flyable plane model string schema
Summary:
New aircraft for XP11 should include a name, author, and studio. These can be used to generate a better model string that doesn't depend on file or directory names.

If the `.acf` contains studio, this is used as the distributor. Otherwise, we use author as distributor instead (truncated in case it is a long list of names).

Then the model string is constructed by combining distributor and model name. If the model name already contains the distributor, we just use the model name.

If the name and distributor are missing, we fall back to the old scheme based on `.acf` filename and dirname.

I have also added a space between aircraft and livery. And I have added default description strings.

After this has landed and been deployed to users, we will need to remove all flyable X-Plane planes from the database and start again with them. (These are the excluded ones.) And we can't accept mappings that use the fallback old scheme if the submitted has renamed the `.acf` file or directory name.

Reviewers: rwinklmeier, kbasan

Reviewed By: kbasan

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D16
2017-05-05 23:07:28 +01:00
Mathew Sutcliffe
fbc9c37646 X-Plane model loader: performance tweaks.
Summary:
Using `QStringRef` and `QLatin1String` to avoid unnecessary allocations and conversions.

Depends on D12.

Reviewers: rwinklmeier, kbasan

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D13
2017-05-05 23:07:27 +01:00
Mathew Sutcliffe
4e23cd1382 X-Plane model loader: support extra properties of .acf files
Summary:
There are optional fields in an X-Plane flyable aircraft that we can use if they are present:

* Description
* Name
* Distributor

If not present, the user has to edit them manually.

@kbasan Any problem with constructing a `CDistributor` with empty db key?

Reviewers: rwinklmeier, kbasan

Reviewed By: rwinklmeier

Subscribers: jenkins, kbasan

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D12
2017-05-05 23:07:25 +01:00
Mathew Sutcliffe
4a4dea8d4d Rename xbus to xswiftbus
Summary:
I wanted to rename xbus because its relation to //swift// is not immediately clear from the name.

xswiftbus seems reasonable.

Reviewers: #swift_pilot_client, kbasan

Reviewed By: kbasan

Subscribers: kbasan, jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D14
2017-05-05 23:07:11 +01:00
Klaus Basan
fad7d4b8c9 Ref T35, optional model description when mapping 2017-05-05 22:40:16 +01:00
Mathew Sutcliffe
e3fe8ec39f refs #937 Resolved clazy warnings: miscellaneous. 2017-04-19 19:31:50 +01:00
Mathew Sutcliffe
045b149164 refs #937 Resolved clazy warnings: Q_ENUMS is deprecated. 2017-04-19 19:31:47 +01:00
Mathew Sutcliffe
3ea9e33e6b refs #937 Resolved clazy warnings: pass-by-value/reference. 2017-04-19 19:31:42 +01:00