Commit Graph

2868 Commits

Author SHA1 Message Date
Klaus Basan
e81211775b RW's review fixes Ref T202 Ref T189 Ref T210
* dmg comment and follow up issue created
* cppcheck-suppress passedByValue in cppcheck.supp
* renamed from Xsb -> XSwiftBus
* reverted wrong "static const QString dataStr"
2017-12-21 19:50:19 +01:00
Klaus Basan
5a24e40312 Ref T210, cppcheck fixes
a) 23	performance	useInitializationList	false	Variable 'm_artifactsPilotClient' is assigned in constructor body. Consider performing initialization in initialization list.
b) 33	performance	passedByValue	false	Function parameter 'il' should be passed by reference.

a) is clear, but b) seems to be wrong, hidden by "cppcheck-suppress"
2017-12-21 19:50:16 +01:00
Klaus Basan
1242c17e7a Formatting 2017-12-21 19:50:13 +01:00
Klaus Basan
8b74acb3a9 Ref T210, moved "guess" into CApplicationInfo
* core unit test, set correct type
* guess application type now in CApplicationInfo
2017-12-21 19:50:09 +01:00
Klaus Basan
cb751306f8 Ref T211, fake and anonymous identifier static const 2017-12-21 19:50:06 +01:00
Klaus Basan
aaf4c35f80 Ref T211, formatting 2017-12-21 19:49:59 +01:00
Klaus Basan
0f8bbbbfc2 Ref T210, adjusting classes to use new functions 2017-12-21 19:49:52 +01:00
Klaus Basan
4a2a059865 Ref T210, "local developer" distribution 2017-12-21 19:49:48 +01:00
Klaus Basan
3269d91baa Ref T210, removed ApplicationModeFlag 2017-12-21 19:49:44 +01:00
Klaus Basan
265869dc1f Ref T210, boolToEnabledDisabled 2017-12-21 19:49:37 +01:00
Klaus Basan
379357d5d5 Formatting 2017-12-21 19:49:34 +01:00
Klaus Basan
a4d4bd7056 Ref T203, fixed gcc issue
static const CPlatform &linux()
platform.h:129:33: error: expected unqualified-id before numeric constant
2017-12-21 19:49:01 +01:00
Klaus Basan
45d02bd22a Ref T203, file utility functions 2017-12-21 19:48:54 +01:00
Klaus Basan
2589b6283b Ref T203, adjusted property index for new classes
* artifact
* update info
2017-12-21 19:48:27 +01:00
Klaus Basan
28225d5611 Ref T203, update info combining artifacts and distributions 2017-12-21 19:48:23 +01:00
Klaus Basan
de7312a869 Ref T203, adjustments for distribution class
* distribution is just the channel, no more the concrete file
* masterdir no longer part of distribution
* using QStringList instead of QSet in some place so sort order is kept
* new utility functions
2017-12-21 19:48:20 +01:00
Klaus Basan
6347c65a2f Ref T203, platform class (OS) 2017-12-21 19:48:13 +01:00
Klaus Basan
54e9d1c429 Ref T203, artifact class (representing something we have build) 2017-12-21 19:48:10 +01:00
Klaus Basan
06f5de205c Ref T203, utility functions for remote files 2017-12-21 19:48:07 +01:00
Klaus Basan
6445444fbf Ref T203, utility functions for URL 2017-12-21 19:48:03 +01:00
Klaus Basan
16a4731389 Ref T203, added folder icons 2017-12-21 19:48:00 +01:00
Klaus Basan
103e55554e Ref T203, fixed missing icons and order in icon list 2017-12-21 19:47:53 +01:00
Klaus Basan
881304dc2f Ref T203, OS icons
(icons from wikipedia marked as public domain)
2017-12-21 19:47:48 +01:00
Klaus Basan
6374e5e10a Some formatting like "this->m_" => "m_"
During Ref T203
2017-12-21 19:47:46 +01:00
Klaus Basan
12b2bc4181 Ref T201, fixes for info object overview
* more detailed log info
* sort info objects so the correct value is obtained ("raw" names)
* check both "duplicate" strings
2017-12-21 19:47:41 +01:00
Klaus Basan
909342e172 Ref T201, formatting 2017-12-21 19:47:39 +01:00
Klaus Basan
7027ba7d77 Delete registrations: https://swift-project.slack.com/archives/C04J6J76N/p1511119242000011
Follow up of Refs #413
2017-12-21 19:47:09 +01:00
Klaus Basan
9cb06c4d56 Ref T192, DBus utility functions, Service name empty for P2P 2017-12-21 19:46:51 +01:00
Klaus Basan
9f889bfce7 Ref T192, case insensitive name check 2017-12-21 19:46:45 +01:00
Klaus Basan
2c2e850668 Ref T192, improved display/log of DBus connection
* log level
* more detailed messages
2017-12-21 19:46:42 +01:00
Klaus Basan
8e761f35f1 Ref T197, simulator info
* CSimulatorInfo only initialized once and not over and over again in plugin info
* getSimulatorInfo() no longer virtual, as we can access the member CSimulatorInfo directly
* display exact simualtor in FSX/P3D driver
* renamed to identifierToSimulator and fixed typo "Identifier"
2017-12-21 19:46:17 +01:00
Klaus Basan
25df9ce720 Ref T195, log category ctor for single element 2017-12-21 19:45:49 +01:00
Klaus Basan
8103df18f7 Ref T195, formatting 2017-12-21 19:45:46 +01:00
Klaus Basan
424d748f25 Ref T195, DBus server utility function 2017-12-21 19:45:43 +01:00
Klaus Basan
075f19268c Ref T192, fixed parsing of DBus string 2017-12-21 19:45:38 +01:00
Klaus Basan
d4b4b48a55 Ref T190, improved display of text messages
* tooltip
* using QStringBuilder
2017-12-21 19:45:22 +01:00
Klaus Basan
c2eeff6193 Ref T189, formatting 2017-12-21 19:45:17 +01:00
Klaus Basan
48adb52082 Ref T190, text messages can be appended
(same sender sends one message in multiple parts)
2017-12-21 19:44:57 +01:00
Klaus Basan
f55332b1ec Ref T190, text message formatting 2017-12-21 19:44:49 +01:00
Roland Winklmeier
f53ec46d20 Change the operating system name from OSX to MacOS everywhere
Summary:
- Changed the name in all build artifacts
- Everywhere in C++

Reviewers: #swift_pilot_client, kbasan

Reviewed By: #swift_pilot_client, kbasan

Subscribers: jenkins

Maniphest Tasks: T205

Differential Revision: https://dev.swift-project.org/D69
2017-12-06 22:50:19 +01:00
Roland Winklmeier
d7d4fdff2c Align the full version schema across all artifacts
Summary:
The version number used for packaging symbols and xswiftbus was not the
full one including the timestamp.
This change adds the last commit timestamp (in contrast to the build
timestamp used before) as regular part of the version number. This helps
us to also keep the version number consistent with the content across all
installers. The version number will change only, if the last commit was
modified and not with each different build.
In the end, all jenkins jobs building from the same commit should produce
artifacts with the same version everywhere.

ref T204

Reviewers: #swift_pilot_client, kbasan

Reviewed By: #swift_pilot_client, kbasan

Subscribers: jenkins

Maniphest Tasks: T204

Differential Revision: https://dev.swift-project.org/D68
2017-12-01 08:13:44 +01:00
Mathew Sutcliffe
047b9279b6 Provide CMessageBase::log for logging with severity configurable as parameter
Summary: Ref T198

Reviewers: kbasan, #swift_developers

Reviewed By: kbasan

Subscribers: jenkins

Tags: #swift_pilot_client

Maniphest Tasks: T198

Differential Revision: https://dev.swift-project.org/D64
2017-11-23 22:15:46 +00:00
Mathew Sutcliffe
3969245a55 Removed "string trick" in CPropertyIndex
Summary:
Ref T187
Using QVector as this is Qt's recommended container type.

Reviewers: #swift_developers, kbasan

Reviewed By: #swift_developers, kbasan

Subscribers: jenkins

Tags: #swift_pilot_client

Maniphest Tasks: T187

Differential Revision: https://dev.swift-project.org/D62
2017-11-23 22:15:37 +00:00
Mathew Sutcliffe
fcb6cf1a52 Removed type erasure in containers
Summary:
Refs T196
Using QVector as this is Qt's recommended container type.

Reviewers: #swift_developers, rwinklmeier

Reviewed By: #swift_developers, rwinklmeier

Subscribers: rwinklmeier, jenkins

Tags: #swift_pilot_client

Maniphest Tasks: T196

Differential Revision: https://dev.swift-project.org/D61
2017-11-23 22:15:23 +00:00
Mathew Sutcliffe
921ef30eda Use C++14 features to simplify our container base classes
Summary: Using C++14 function return type deduction we can simplify the CRTP in CContainerBase etc.

Reviewers: #swift_developers, rwinklmeier

Reviewed By: #swift_developers, rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D65
2017-11-23 21:59:09 +00:00
Mathew Sutcliffe
e8219efdde Removed own implementation of std::index_sequence that was needed for GCC 4.9. 2017-11-14 17:51:09 +00:00
Mathew Sutcliffe
0b67466480 Removed workarounds in metaclass system that were needed for GCC 4.9 and old MSVC. 2017-11-14 17:51:07 +00:00
Mathew Sutcliffe
77b6a1ccb0 Removed workarounds that were needed to support GCC 4.9. 2017-11-14 17:51:04 +00:00
Mathew Sutcliffe
3ae5e274ee Removed workarounds that were needed to support older versions of MSVC. 2017-11-14 17:51:02 +00:00
Mathew Sutcliffe
0cae43197c Consume all console output of ping process, to avoid noise in test output. 2017-11-12 21:20:09 +00:00