Commit Graph

4924 Commits

Author SHA1 Message Date
Mathew Sutcliffe
de11f7fe35 Correctly remove session cache value of expired session.
Summary:
`CDataCacheRevision` stores current working timestamps in `m_timestamps` and stores complete timestamps (including unadmitted deferred values) in `m_originalTimestamps`. A value is "in" the cache if and only if its timestamp is in `m_timestamps`. In `writeNewRevision` the `.rev` file is written based on `m_originalTimestamps` so that unadmitted deferred values don't get lost.

Session cache works by removing timestamps that were not created in the current session. But it needs to remove from both `m_timestamps` and `m_originalTimestamps` so that old session cache values can't get recreated by `writeNewRevision`.

Test Plan: Currently being evaluated by @kbasan to check that it does not introduce unintended consequences.

Reviewers: #swift_pilot_client, kbasan

Reviewed By: #swift_pilot_client, kbasan

Subscribers: jenkins, kbasan

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D53
2017-09-24 19:53:41 +01:00
Mathew Sutcliffe
e98662d530 Allow setting VATSIM key on qmake commandline.
Summary: By qualifying the key with `isEmpty` it prevents overwriting a value specified on the commandline.

Reviewers: rwinklmeier

Reviewed By: rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D51
2017-09-24 19:53:40 +01:00
Mathew Sutcliffe
f1211d328e Delete QDBusServiceWatcher when unloading X-Plane driver.
Summary:
When unloading a sim driver, first its threads are killed, then the driver object is destroyed.

This means that when the `QDBusServiceWatcher` child object is destroyed, it deadlocks waiting for a thread that was already killed (T147).

This change causes the `QDBusServiceWatcher` to be deleted before the driver is unloaded.

Reviewers: #swift_pilot_client, kbasan, rwinklmeier

Reviewed By: #swift_pilot_client, kbasan, rwinklmeier

Subscribers: kbasan, jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D50
2017-09-24 19:53:38 +01:00
Roland Winklmeier
e2b00f1f9b Fix typo in header guard 2017-09-24 19:53:37 +01:00
Roland Winklmeier
27f97e8ac8 Implement interpolator mode for FS9
Summary:
This implementation will always return true if we were setting the mode,
since we cannot easily access the return value from
CInterpolatorMulti::setMode in a thread safe manner.

Reviewers: #swift_pilot_client, kbasan, msutcliffe

Reviewed By: #swift_pilot_client, kbasan, msutcliffe

Subscribers: kbasan, jenkins

Differential Revision: https://dev.swift-project.org/D52
2017-09-24 19:53:35 +01:00
Roland Winklmeier
09da34d8f0 Update of sound effect files
- error
- frequencymessage
- privatemessage
- voiceroomjoined
- voiceroomleft

ref T119
2017-09-24 19:53:34 +01:00
Roland Winklmeier
0b40450f7b Remove xswiftbus from installer
Summary:
xswiftbus is now a downloadable standalone X-Plane fat plugin and should
no longer be packaged into the installer.

Reviewers: #swift_pilot_client, msutcliffe

Reviewed By: #swift_pilot_client, msutcliffe

Subscribers: jenkins

Maniphest Tasks: T123

Differential Revision: https://dev.swift-project.org/D49
2017-09-24 19:53:32 +01:00
Klaus Basan
2b3b173b76 Default calculation of distance/bearing for airports. Follow up of the discussion in slack/during T125
Summary: Default calculation of distance/bearing for airports.

Reviewers: msutcliffe, rwinklmeier

Reviewed By: msutcliffe, rwinklmeier

Subscribers: jenkins

Maniphest Tasks: T125

Differential Revision: https://dev.swift-project.org/D48
2017-09-24 19:53:31 +01:00
Klaus Basan
73556492fd Ref T125, use XSwiftBus download component
* as dialog in distribution component
* in wizard
2017-09-24 19:53:29 +01:00
Klaus Basan
76c1b0307c Ref T125, UI component to download and install XSwiftBus
* currently working only for alpha directory
* 1st version, maybe currently too much logic (download etc.) in an UI component
2017-09-24 19:53:28 +01:00
Klaus Basan
dec5eff0c6 Ref T125, service to download and save file in directory 2017-09-24 19:53:26 +01:00
Klaus Basan
50442e6f13 Ref T125, value class for remote files (i.e. files downloaded). Corresponds with backend service T132 2017-09-24 19:53:24 +01:00
Klaus Basan
8d72fe5285 Ref T125, allow to use std::function with CSlot 2017-09-24 19:53:23 +01:00
Klaus Basan
d4b027b6bd Ref T125, X-Plane config now only XSwiftBus settings, no longer installation 2017-09-24 19:53:21 +01:00
Klaus Basan
329b0512eb Ref T125, utility functions 2017-09-24 19:53:20 +01:00
Klaus Basan
c6f3a7033d Ref T125, own component for XSwiftBus settings. This component can be used in the installation and plugin UI. 2017-09-24 19:53:18 +01:00
Klaus Basan
12db652ccf Ref T125, renaming areAllDataRead => areAllInfoObjectsRead 2017-09-24 19:53:17 +01:00
Klaus Basan
53189eafd5 Ref T125, human readable file size 2017-09-24 19:53:15 +01:00
Klaus Basan
8c032fb4d7 Ref T125, allow to get distribution list by JSON string. Also setup value object directly using JSON string now. 2017-09-24 19:53:13 +01:00
Klaus Basan
15f5a7f489 Ref T125, URL for XSwiftBus file info webservice 2017-09-24 19:53:12 +01:00
Klaus Basan
0bbad2ff83 Minor tweaks (found during T125)
* formatting/typos
* authentication: private slots => private
2017-09-24 19:53:10 +01:00
Klaus Basan
ca651877cd Load overview component fixes and formatting
* this->m_XX => m_XX
* private slots => private
* GUI updates only via digest signal, and slower (was called too often)
* flag to avoid gui updates when another gui update is still in progress (possible because of canConnect/processEvent situation)
2017-09-24 19:53:09 +01:00
Klaus Basan
a993ccd1c1 Fix CApplication::processEventsFor so it can be used in samples/unit tests 2017-09-24 19:53:07 +01:00
Klaus Basan
769e3a0e29 Based on slack discussion MS/KB: Show airports in range also when simulator is connected, but network is not. Remark: distance and bearing columns are not calculated in that case. See T125 comment for details. 2017-09-24 19:53:06 +01:00
Klaus Basan
65bd2d20ad Ref T125, X-Plan utility functions and moved XSwiftBus settings in own file 2017-09-24 19:53:03 +01:00
Klaus Basan
104d869c19 Ref T125, fixed to static const 2017-09-24 19:53:01 +01:00
Klaus Basan
16c2881e6a New FSD testserver (on swift machines) 2017-09-24 19:53:00 +01:00
Klaus Basan
d995bcf59c Ref T126, fixed too early timeout
* use timeout timestamp
* used approch with trials was wrong, as number of trials also depends on number of reader
2017-09-24 19:52:58 +01:00
Klaus Basan
f694ded5f2 Preparation of T126: Minor tweaks, renaming and formatting of InfoDataReader
* unified member access (this->m_xy => m_xy)
* set object name of readers
* waitForSharedInfoObjectsThenRead (not just waiting, also reading afterwards)
2017-09-24 19:52:56 +01:00
Mathew Sutcliffe
2387edb5a0 Removed C++14 digit separator as it confuses doxygen.
See https://bugzilla.gnome.org/show_bug.cgi?id=786382
2017-09-24 19:52:54 +01:00
Mathew Sutcliffe
1888367e95 T37 T134 Removed asserts that reflect broken assumptions. 2017-09-24 19:52:53 +01:00
Mathew Sutcliffe
1cd471873f T37 T133 removeOutdatedParts shall always preserve one outdated parts
to make sure there is enough information to reliably interpolate.
2017-09-24 19:52:51 +01:00
Mathew Sutcliffe
de13fc51cb T37 T130 Workaround to consolidate time offset to all places it is needed. 2017-09-24 19:52:50 +01:00
Mathew Sutcliffe
f9ae3efaa3 T37 Avoid division by zero in case time offset is zero. 2017-09-24 19:52:49 +01:00
Mathew Sutcliffe
98e0f8c875 T37 T127 Send timestamps to XSwiftBus as separate timestamp and offset
as the offset is needed for reliable interpolation.
2017-09-24 19:52:46 +01:00
Mathew Sutcliffe
aaeb2e8ceb T37 Fixed wrong parameter names. 2017-09-24 19:52:44 +01:00
Roland Winklmeier
c91aa0d58e Change template parameter to disambiguate call to QLatin1String constructor
Summary:
Qt 5.10 added a new constructor overload which made the call to QLatin1String
constructor with size_t as second parameter ambigious.

Reviewers: #swift_pilot_client, msutcliffe

Reviewed By: #swift_pilot_client, msutcliffe

Subscribers: jenkins

Differential Revision: https://dev.swift-project.org/D47
2017-09-24 19:52:41 +01:00
Roland Winklmeier
4b34aff39d Update FSD url in network unit test 2017-09-24 19:52:39 +01:00
Mathew Sutcliffe
05c0d046aa Removed outdated todos. 2017-09-24 19:52:37 +01:00
Roland Winklmeier
d505f7b9a4 Disable installing of Bitrock auto updater
Summary:
Disabling happens in two steps. The binary was created as dependent target
of 'make create_installer'. This step is now skipped.
The second step is to remove it from the installbuilder project
configuration.
Disabling only so far to easily get it back if needed.

ref T124

Reviewers: #swift_pilot_client, msutcliffe

Reviewed By: #swift_pilot_client, msutcliffe

Subscribers: jenkins

Maniphest Tasks: T124

Differential Revision: https://dev.swift-project.org/D46
2017-09-24 19:52:34 +01:00
Klaus Basan
3f924209f1 As a follow up of review T111, changed "void static" to "static void" for consistency. 2017-09-24 19:52:31 +01:00
Klaus Basan
addb008ffa Pass back URLs for changed URL check. This allows to display the changed locations. 2017-09-24 19:52:28 +01:00
Klaus Basan
e89d7d7b15 Log status when news is received 2017-09-24 19:52:25 +01:00
Klaus Basan
8119aafca4 Move URLs getter to cpp. This is a tweak so I can easily change the URLs for testing. 2017-09-24 19:52:22 +01:00
Klaus Basan
991cc3463d Ref T117, check equal models before publishing
* checkbox, check can be disabled
* context menu to display changed attributes in popup
2017-09-24 19:52:19 +01:00
Klaus Basan
5a67276fbb Ref T117, utility functions for reader
* isDbModelEqualForPublishing
* getModelForDbKey(int
2017-09-24 19:52:16 +01:00
Klaus Basan
fe3368e1f4 Ref T117, formatting 2017-09-24 19:52:15 +01:00
Klaus Basan
9903d518b0 Ref T117, utility functions
* detect equal models (equal in sense of "equal for publishing", not ==)
* severity functions for message list
2017-09-24 19:52:14 +01:00
Klaus Basan
202c37beca Updated credits 2017-09-24 19:52:13 +01:00
Klaus Basan
da47be641a Typo 2017-09-24 19:52:11 +01:00