Summary:
`CDataCacheRevision` stores current working timestamps in `m_timestamps` and stores complete timestamps (including unadmitted deferred values) in `m_originalTimestamps`. A value is "in" the cache if and only if its timestamp is in `m_timestamps`. In `writeNewRevision` the `.rev` file is written based on `m_originalTimestamps` so that unadmitted deferred values don't get lost.
Session cache works by removing timestamps that were not created in the current session. But it needs to remove from both `m_timestamps` and `m_originalTimestamps` so that old session cache values can't get recreated by `writeNewRevision`.
Test Plan: Currently being evaluated by @kbasan to check that it does not introduce unintended consequences.
Reviewers: #swift_pilot_client, kbasan
Reviewed By: #swift_pilot_client, kbasan
Subscribers: jenkins, kbasan
Tags: #swift_pilot_client
Differential Revision: https://dev.swift-project.org/D53
Summary: By qualifying the key with `isEmpty` it prevents overwriting a value specified on the commandline.
Reviewers: rwinklmeier
Reviewed By: rwinklmeier
Subscribers: jenkins
Tags: #swift_pilot_client
Differential Revision: https://dev.swift-project.org/D51
Summary:
When unloading a sim driver, first its threads are killed, then the driver object is destroyed.
This means that when the `QDBusServiceWatcher` child object is destroyed, it deadlocks waiting for a thread that was already killed (T147).
This change causes the `QDBusServiceWatcher` to be deleted before the driver is unloaded.
Reviewers: #swift_pilot_client, kbasan, rwinklmeier
Reviewed By: #swift_pilot_client, kbasan, rwinklmeier
Subscribers: kbasan, jenkins
Tags: #swift_pilot_client
Differential Revision: https://dev.swift-project.org/D50
Summary:
This implementation will always return true if we were setting the mode,
since we cannot easily access the return value from
CInterpolatorMulti::setMode in a thread safe manner.
Reviewers: #swift_pilot_client, kbasan, msutcliffe
Reviewed By: #swift_pilot_client, kbasan, msutcliffe
Subscribers: kbasan, jenkins
Differential Revision: https://dev.swift-project.org/D52
Summary:
xswiftbus is now a downloadable standalone X-Plane fat plugin and should
no longer be packaged into the installer.
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Maniphest Tasks: T123
Differential Revision: https://dev.swift-project.org/D49
* this->m_XX => m_XX
* private slots => private
* GUI updates only via digest signal, and slower (was called too often)
* flag to avoid gui updates when another gui update is still in progress (possible because of canConnect/processEvent situation)
* unified member access (this->m_xy => m_xy)
* set object name of readers
* waitForSharedInfoObjectsThenRead (not just waiting, also reading afterwards)
Summary:
Qt 5.10 added a new constructor overload which made the call to QLatin1String
constructor with size_t as second parameter ambigious.
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Differential Revision: https://dev.swift-project.org/D47
Summary:
Disabling happens in two steps. The binary was created as dependent target
of 'make create_installer'. This step is now skipped.
The second step is to remove it from the installbuilder project
configuration.
Disabling only so far to easily get it back if needed.
ref T124
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Subscribers: jenkins
Maniphest Tasks: T124
Differential Revision: https://dev.swift-project.org/D46