Summary:
Backtrace accepts a wide range of native debugging formats, e.g. PDB, dSYM, ELF files. Instead of converting to an intermediate format being breakpad sym files, package and upload the native formats directly.
Also reduce the list of debugging symbols to a reasonable minimum. Sample and test symbols are not required.
Reviewers: #gatekeepers, msutcliffe
Reviewed By: #gatekeepers, msutcliffe
Subscribers: msutcliffe
Maniphest Tasks: T588
Differential Revision: https://dev.swift-project.org/D102
Adding Qwt as a library added a couple of more Qt5 dependencies that were undetected so far. So I went through all our binaries and dependencies and tried to find all required sub dependencies. After that, the lists have been sorted for easier maintenance.
Summary:
swift_crashpad_handler for Linux was part of externals but was never copied to out/
and also never copied into the installer.
Reviewers: #gatekeepers
Differential Revision: https://dev.swift-project.org/D96
Test Plan:
- Check that the new shared libraries are packaged in all platform installers.
- check that plugins are loaded properly on all platforms.
Reviewers: #swift_pilot_client, msutcliffe
Reviewed By: #swift_pilot_client, msutcliffe
Maniphest Tasks: T471
Differential Revision: https://dev.swift-project.org/D79
Requiring general root privileges raised some trust concerns by MacOS users. This reverts the latest changes to require root to install DBus machine-id into /etc. Now the user has to do that manually via sudo. A check will be added before running into an assert.
- It got splitted up into a x86 and x64 component.
- Each one is packaged only for the respective archictecture
- Always run the installer without registry checks and evaluate the return
code. Raise a warning only if its not 0 and not 1638 (newer version already
installed).
ref T344
The name was not set at all and was falling back to the fullname being swift.
Instead set it explicitly to fullname including version and architecture.
The productDisplayIcon is evaluated at installer runtime and needs to be
set to a installed icon path.
The installer icon itself was to big (> 100 kb) and got unnecessary sizes
removed.
ref T344
In the previous logic, the installer would silently ignore missing binaries.
Instead it should error, if a binary is missing that should exist for
this installer architecture.
ref T344
In case, vcredist returns a non zero return code, don't automatically
abort the installation, but tell the user the error code, the consequences
and continue.
ref T344
MSVC 2017 was updated to v15.7 in Jenkins CI and with it also the redist
version numbers. However, the new version was never updated in the installer
and packaging project.
Summary:
- Changed the name in all build artifacts
- Everywhere in C++
Reviewers: #swift_pilot_client, kbasan
Reviewed By: #swift_pilot_client, kbasan
Subscribers: jenkins
Maniphest Tasks: T205
Differential Revision: https://dev.swift-project.org/D69
