Commit Graph

4 Commits

Author SHA1 Message Date
Klaus Basan
e81211775b RW's review fixes Ref T202 Ref T189 Ref T210
* dmg comment and follow up issue created
* cppcheck-suppress passedByValue in cppcheck.supp
* renamed from Xsb -> XSwiftBus
* reverted wrong "static const QString dataStr"
2017-12-21 19:50:19 +01:00
Klaus Basan
5a24e40312 Ref T210, cppcheck fixes
a) 23	performance	useInitializationList	false	Variable 'm_artifactsPilotClient' is assigned in constructor body. Consider performing initialization in initialization list.
b) 33	performance	passedByValue	false	Function parameter 'il' should be passed by reference.

a) is clear, but b) seems to be wrong, hidden by "cppcheck-suppress"
2017-12-21 19:50:16 +01:00
Klaus Basan
a4d4bd7056 Ref T203, fixed gcc issue
static const CPlatform &linux()
platform.h:129:33: error: expected unqualified-id before numeric constant
2017-12-21 19:49:01 +01:00
Klaus Basan
6347c65a2f Ref T203, platform class (OS) 2017-12-21 19:48:13 +01:00