Commit Graph

104 Commits

Author SHA1 Message Date
Lars Toenning
d4fdc6e17b Prevent saving invalid values
If a value has not changed and should be saved to a file, only the key (and the invalid value) was passed to the save function. The save function does not check this case or read the value from the cache.
This happens when changing simulator paths as the settings are updated and saved separately.
2022-05-25 19:47:35 +01:00
Lars Toenning
c0efc9ea81 Clean up includes 2022-05-25 19:47:34 +01:00
Mat Sutcliffe
eb6b0ff289 Fix clang-tidy and clazy warnings 2021-08-29 17:02:27 +01:00
Mat Sutcliffe
33209fa1eb Use std::as_const (C++17 feature) 2021-07-13 17:56:31 +01:00
Mat Sutcliffe
7955d0a06e Remove workarounds for fixed bugs 2021-07-13 17:56:23 +01:00
Mat Sutcliffe
371c1f4f7c Issue #77 Break cyclic dependency between CLogCategory and numerous classes 2020-12-19 18:50:34 +00:00
Mat Sutcliffe
63e8de8f00 Issue #77 getLogCategories returns a simple QStringList instead of our own class 2020-12-19 18:50:34 +00:00
Mat Sutcliffe
bb8aeaa3d0 Fix build with Clang on Windows 2020-08-29 14:16:17 +01:00
Mat Sutcliffe
8e065a8fef Issue #77 Factor out parts of CDirectoryUtils into CSwiftDirectories
CDirectoryUtils is utilities for manipulating directories.
CSwiftDirectories is getters that return directories used by swift.
2020-08-29 14:16:12 +01:00
Klaus Basan
6284ed0c5a Minor style adjustments 2020-01-18 02:48:28 +01:00
Mat Sutcliffe
4a0d8e9864 Fixed most Qt 5.14 deprecation warnings 2020-01-07 19:57:25 +00:00
Mat Sutcliffe
668a77d083 Ref T689 Settings validation can produce more descriptive error messages. 2019-09-16 22:40:05 +01:00
Mat Sutcliffe
c8d2f2be7e Return status message when value is not set because it was unchanged. 2019-04-12 14:54:47 +01:00
Mat Sutcliffe
5521a20883 Swap comparison order in case the value expensive to compare. 2019-04-12 14:54:46 +01:00
Mat Sutcliffe
d29576b67a Ref T552 Register value classes with qRegisterMetaTypeStreamOperators. 2019-04-12 13:57:17 +01:00
Mat Sutcliffe
e9a4c49d68 Ref T547 Update license masthead in all source code files. 2019-02-22 20:36:43 +00:00
Mat Sutcliffe
fe7a45afcf Ref T516 Update CStatusMessage call sites to use new syntax. 2019-02-22 20:35:51 +00:00
Mat Sutcliffe
225ff81252 Ref T485 Adjust CLogMessage and CStatusMessage call sites to use the new API. 2019-02-22 20:34:55 +00:00
Mat Sutcliffe
6c05c5249d When calling arg() on a QString constructed from a literal, use QStringLiteral. 2019-02-22 20:23:47 +00:00
Mat Sutcliffe
9f85a7b560 Fixed clazy warnings: pass large objects by reference to const. 2019-02-22 20:23:33 +00:00
Klaus Basan
6bcded9264 Style 2018-07-09 22:30:20 +02:00
Klaus Basan
2c5a6c0a3a Ref T218, renamed some functions of CIdentifier 2018-01-14 18:45:48 +01:00
Mathew Sutcliffe
9da798e470 Ref T155 Log category for CValuePage. 2017-09-24 19:53:43 +01:00
Klaus Basan
a9198e4f13 Ref T103, Unified naming of directory functions
* some started with get/some not (removed get, get is normally used for our getters)
* some used swift, getSwiftXZY dir (removed swift)
* used full word "directory", not dir/directory mixed
2017-09-24 19:49:53 +01:00
Klaus Basan
297ef8ea16 Ref T42, single quote around value 2017-05-05 23:07:36 +01:00
Mathew Sutcliffe
b7f69c6887 refs #937 Resolved clazy warnings: unnecessary memory allocation. 2017-04-19 19:31:39 +01:00
Mathew Sutcliffe
fce1513dae refs #937 Resolved clazy warnings: unnecessary detaching of containers. 2017-04-19 19:31:38 +01:00
Mathew Sutcliffe
70224bea72 refs #904 Settings JSON files split into arbitrary levels of subfolders, one file per key. 2017-04-17 23:59:00 +01:00
Klaus Basan
888375d294 refs #887, directories available via CDirectoryUtils/relative paths
* relative cache/settings paths are available relativeFilePath
* directories build in CDirectoryUtils
* directory comparison in CDirectoryUtils
* using CFileUtils to concatenate dir paths
* using URL encoded string for normalized directory (as it can be decoded)
2017-03-01 20:51:34 +01:00
Mathew Sutcliffe
a0d3461d9b refs #884 CValueCache::getAllValues should skip empty values. 2017-02-28 22:34:50 +00:00
Mathew Sutcliffe
c268581954 refs #885 Regenerate revision file from available JSON files. 2017-02-25 02:11:13 +00:00
Mathew Sutcliffe
045b2a9f59 refs #815 When a cache/settings file has errors, back it up before it can be overwritten. 2017-01-10 23:46:38 +00:00
Mathew Sutcliffe
51c3ae8c25 refs #815 Catch and handle CJsonException when calling convertFromJson. 2017-01-10 23:46:36 +00:00
Klaus Basan
3f2fc33b27 Minor change, added ' in error messages 2017-01-10 23:46:08 +00:00
Mathew Sutcliffe
ef04c05831 refs #847 Missing cache directory is not an error, just means there is nothing to load. 2017-01-10 23:45:16 +00:00
Mathew Sutcliffe
34f7acbf8d refs #847 Fixed apparent copy/paste mistake. 2017-01-10 23:45:15 +00:00
Mathew Sutcliffe
8e6422d2be Added assert. 2016-12-13 19:01:57 +01:00
Klaus Basan
bd14fd3746 refs #817, wrong cache ts fix as discussed
https://dev.vatsim-germany.org/issues/817#note-1
2016-12-13 19:01:21 +01:00
Mathew Sutcliffe
3c40c1026e refs #802 Fixed internal compiler errors with Clang on Windows. 2016-12-13 19:00:43 +01:00
Mathew Sutcliffe
2ab2819867 refs #784 Adjust CValueCache to use the new JSON schema. 2016-12-13 19:00:21 +01:00
Mathew Sutcliffe
8a65a33384 refs #684, #766, #776 Support %OwnerName% in cache keys by allowing CCached::m_element to be a dummy
and by using a trick with explicit destructor call and placement new to reconstruct CCached when owner's name changes.
2016-10-17 14:37:47 +01:00
Mathew Sutcliffe
898b8e4078 refs #684 Added parametrised cache value key strings. 2016-09-19 16:18:53 +02:00
Mathew Sutcliffe
aeb15ea7be refs #759, #761 Track when a cache value notify slot is a member function to avoid duplicate calls. 2016-09-19 16:18:52 +02:00
Mathew Sutcliffe
e01ae2be11 refs #759 Allow cache value notification slot to be changed after construction.
Also allow slot to be any type of callable, including member function or lambda.
2016-09-19 16:18:52 +02:00
Mathew Sutcliffe
661254371c refs #730 Avoid duplicate "empty cache value" debug messages. 2016-08-26 21:04:49 +01:00
Mathew Sutcliffe
98a2b3253a refs #694 Use human readable names in cache validation messages. 2016-07-31 23:17:46 +01:00
Mathew Sutcliffe
87b2396edb refs #694 Support human readable names for settings and data cache traits. 2016-07-31 23:15:35 +01:00
Mathew Sutcliffe
61f3655b2c refs #695 Allow to set a mock root directory for caches, for unit tests. 2016-07-29 17:09:08 +01:00
Mathew Sutcliffe
843620ca3c Caches: method to save values given a list of keys. 2016-06-30 22:20:32 +01:00
Mathew Sutcliffe
242e041ceb refs #679 CValueCache local signal relay moved to the point of emission, to tolerate different orders of initialization of application. 2016-06-30 02:06:16 +01:00