From 0ecc2d9f24a5afca289f3d8429480f7b7805ce02 Mon Sep 17 00:00:00 2001
From: jenjac <40074036+jenjac@users.noreply.github.com>
Date: Wed, 10 Oct 2018 12:06:24 -0500
Subject: [PATCH] GET to POST and POST to PUT for v1/apps endpoint (#525)

Changed GET to POST for "get apps" as a GET with a request body is not preferred.

Changed POST to PUT for "upload apps" as POST is now used for "get apps".
---
 platform/appstore/client.go | 4 ++--
 platform/appstore/server.go | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/platform/appstore/client.go b/platform/appstore/client.go
index d426af47..31c8f992 100644
--- a/platform/appstore/client.go
+++ b/platform/appstore/client.go
@@ -19,7 +19,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp
 	var appUploadEndpoint endpoint.Endpoint
 	{
 		appUploadEndpoint = httptransport.NewClient(
-			"POST",
+			"PUT",
 			httputil.CopyURL(u, "/v1/apps"),
 			httputil.EncodeRequestWithToken(token, encodeUploadAppRequest),
 			decodeUploadAppResponse,
@@ -30,7 +30,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp
 	var listAppsEndpoint endpoint.Endpoint
 	{
 		listAppsEndpoint = httptransport.NewClient(
-			"GET",
+			"POST",
 			httputil.CopyURL(u, "/v1/apps"),
 			httputil.EncodeRequestWithToken(token, httptransport.EncodeJSONRequest),
 			decodeListAppsResponse,
diff --git a/platform/appstore/server.go b/platform/appstore/server.go
index b45123d4..8465e7b0 100644
--- a/platform/appstore/server.go
+++ b/platform/appstore/server.go
@@ -21,17 +21,17 @@ func MakeServerEndpoints(s Service, outer endpoint.Middleware, others ...endpoin
 }
 
 func RegisterHTTPHandlers(r *mux.Router, e Endpoints, options ...httptransport.ServerOption) {
-	// POST    /v1/apps			upload an app to the server
-	// GET     /v1/apps			list apps managed by the server
+	// PUT		/v1/apps			upload an app to the server
+	// POST   /v1/apps			list apps managed by the server
 
-	r.Methods("POST").Path("/v1/apps").Handler(httptransport.NewServer(
+	r.Methods("PUT").Path("/v1/apps").Handler(httptransport.NewServer(
 		e.AppUploadEndpoint,
 		decodeAppUploadRequest,
 		httputil.EncodeJSONResponse,
 		options...,
 	))
 
-	r.Methods("GET").Path("/v1/apps").Handler(httptransport.NewServer(
+	r.Methods("POST").Path("/v1/apps").Handler(httptransport.NewServer(
 		e.ListAppsEndpoint,
 		decodeListAppsRequest,
 		httputil.EncodeJSONResponse,