From 323c05b230a1115a3f0cb1bd8bc02fbf2888a027 Mon Sep 17 00:00:00 2001 From: jenjac <40074036+jenjac@users.noreply.github.com> Date: Wed, 10 Oct 2018 11:32:46 -0500 Subject: [PATCH] GET to POST for v1/profiles endpoint (#523) Changed GET to POST as a GET with a request body is not preferred. --- platform/profile/client.go | 2 +- platform/profile/server.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/platform/profile/client.go b/platform/profile/client.go index 4e933c30..c26c78f3 100644 --- a/platform/profile/client.go +++ b/platform/profile/client.go @@ -29,7 +29,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp var getProfilesEndpoint endpoint.Endpoint { getProfilesEndpoint = httptransport.NewClient( - "GET", + "POST", httputil.CopyURL(u, "/v1/profiles"), httputil.EncodeRequestWithToken(token, httptransport.EncodeJSONRequest), decodeGetProfilesResponse, diff --git a/platform/profile/server.go b/platform/profile/server.go index 3f5dabe3..2bd8d3fe 100644 --- a/platform/profile/server.go +++ b/platform/profile/server.go @@ -22,11 +22,11 @@ func MakeServerEndpoints(s Service, outer endpoint.Middleware, others ...endpoin } func RegisterHTTPHandlers(r *mux.Router, e Endpoints, options ...httptransport.ServerOption) { - // GET /v1/profiles get a list of profiles managed by the server + // POST /v1/profiles get a list of profiles managed by the server // PUT /v1/profiles create or replace a profile on the server // DELETE /v1/profiles remove one or more profiles from the server - r.Methods("GET").Path("/v1/profiles").Handler(httptransport.NewServer( + r.Methods("POST").Path("/v1/profiles").Handler(httptransport.NewServer( e.GetProfilesEndpoint, decodeGetProfilesRequest, httputil.EncodeJSONResponse,