From bec5193b88bf794c64aacb34bda654d77f3ea672 Mon Sep 17 00:00:00 2001 From: jenjac <40074036+jenjac@users.noreply.github.com> Date: Wed, 10 Oct 2018 12:23:02 -0500 Subject: [PATCH] GET to POST for v1/users endpoint (#526) Changed GET to POST as a GET with a request body is not preferred. --- platform/user/client.go | 2 +- platform/user/server.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/platform/user/client.go b/platform/user/client.go index 020cdc34..abdd114b 100644 --- a/platform/user/client.go +++ b/platform/user/client.go @@ -29,7 +29,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp var listUsersEndpoint endpoint.Endpoint { listUsersEndpoint = httptransport.NewClient( - "GET", + "POST", httputil.CopyURL(u, "/v1/users"), httputil.EncodeRequestWithToken(token, httptransport.EncodeJSONRequest), decodeListUsersResponse, diff --git a/platform/user/server.go b/platform/user/server.go index 1119290e..56435a9b 100644 --- a/platform/user/server.go +++ b/platform/user/server.go @@ -22,7 +22,7 @@ func MakeServerEndpoints(s Service, outer endpoint.Middleware, others ...endpoin func RegisterHTTPHandlers(r *mux.Router, e Endpoints, options ...httptransport.ServerOption) { // PUT /v1/users create or replace an user - // GET /v1/users get a list of users managed by the server + // POST /v1/users get a list of users managed by the server r.Methods("PUT").Path("/v1/users").Handler(httptransport.NewServer( e.ApplyUserEndpoint, @@ -31,7 +31,7 @@ func RegisterHTTPHandlers(r *mux.Router, e Endpoints, options ...httptransport.S options..., )) - r.Methods("GET").Path("/v1/users").Handler(httptransport.NewServer( + r.Methods("POST").Path("/v1/users").Handler(httptransport.NewServer( e.ListUsersEndpoint, decodeListUsersRequest, httputil.EncodeJSONResponse,