* Spring cleaning on Region.Environment.

* Converted a large number of read-only fields to be actually, readonly.
* Reformatted code sections.
* Removed redundant code.
This commit is contained in:
Adam Frisby
2008-05-01 16:35:00 +00:00
parent 01f31fd933
commit 13526097f2
76 changed files with 4181 additions and 4314 deletions

View File

@@ -42,11 +42,11 @@ namespace OpenSim.Region.Environment.Modules.Framework
public class Command : ICommand
{
private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
private List<CommandArgument> m_args = new List<CommandArgument>();
private readonly List<CommandArgument> m_args = new List<CommandArgument>();
private Action<object[]> m_command;
private string m_help;
private string m_name;
private readonly Action<object[]> m_command;
private readonly string m_help;
private readonly string m_name;
public Command(string name, Action<Object[]> command, string help)
{
@@ -164,9 +164,9 @@ namespace OpenSim.Region.Environment.Modules.Framework
/// </summary>
public class CommandArgument
{
private string m_help;
private string m_name;
private string m_type;
private readonly string m_help;
private readonly string m_name;
private readonly string m_type;
private Object m_val;
public CommandArgument(string name, string help, string type)
@@ -204,8 +204,8 @@ namespace OpenSim.Region.Environment.Modules.Framework
public class Commander : ICommander
{
private static readonly ILog m_log = LogManager.GetLogger(MethodBase.GetCurrentMethod().DeclaringType);
private Dictionary<string, ICommand> m_commands = new Dictionary<string, ICommand>();
private string m_name;
private readonly Dictionary<string, ICommand> m_commands = new Dictionary<string, ICommand>();
private readonly string m_name;
public Commander(string name)
{
@@ -235,11 +235,11 @@ namespace OpenSim.Region.Environment.Modules.Framework
}
classSrc = classSrc.Remove(classSrc.Length - 1); // Delete the last comma
classSrc += " )\n\t{\n";
classSrc += "\t\tObject[] args = new Object[" + com.Arguments.Count.ToString() + "];\n";
classSrc += "\t\tObject[] args = new Object[" + com.Arguments.Count + "];\n";
int i = 0;
foreach (KeyValuePair<string, string> arg in com.Arguments)
{
classSrc += "\t\targs[" + i.ToString() + "] = " + Util.Md5Hash(arg.Key) + " " + ";\n";
classSrc += "\t\targs[" + i + "] = " + Util.Md5Hash(arg.Key) + " " + ";\n";
i++;
}
classSrc += "\t\tGetCommander(\"" + m_name + "\").Run(\"" + com.Name + "\", args);\n";

View File

@@ -34,7 +34,7 @@ namespace OpenSim.Region.Environment.Modules.Framework
{
public class CommanderTestModule : IRegionModule, ICommandableModule
{
private Commander m_commander = new Commander("CommanderTest");
private readonly Commander m_commander = new Commander("CommanderTest");
private Scene m_scene;
#region ICommandableModule Members