Attachment persistence!!! Patch #9169 (Mantis #1171)

Attachments now save to MySQL. No reattach on login yet.

OpenSim/Data/MySQL/MySQLUserData.cs

@@ -834,14 +834,15 @@ namespace OpenSim.Data.MySQL
 
             IDataReader r = cmd.ExecuteReader();
 
-            return database.readAttachments(r);
+            Hashtable ret =  database.readAttachments(r);
+
+            r.Close();
+
+            return ret;
         }
 
         public void UpdateUserAttachments(LLUUID agentID, Hashtable data)
         {
-            if(data == null)
-                return;
-
             database.writeAttachments(agentID, data);
         }
     }