- moving banned check and public/private check to

Scene.NewUserConnection()
- adding reason reporting

this enforces estate bans very early on and prevents us from
circulating client objects that we'd then have to retract once we
realize that the client is not allowed into the region

OpenSim/Tests/Common/Setup/SceneSetupHelpers.cs

@@ -245,9 +245,11 @@ namespace OpenSim.Tests.Common.Setup
         /// <returns></returns>
         public static TestClient AddRootAgent(Scene scene, AgentCircuitData agentData)
         {
+            string reason;
+
             // We emulate the proper login sequence here by doing things in three stages
             // Stage 1: simulate login by telling the scene to expect a new user connection
-            scene.NewUserConnection(agentData);
+            scene.NewUserConnection(agentData, out reason);
 
             // Stage 2: add the new client as a child agent to the scene
             TestClient client = new TestClient(agentData, scene);