From e4406c846d74212493890a46922292cd7fec2ea5 Mon Sep 17 00:00:00 2001
From: Snoopy Pfeffer <snoopy.pfeffer@yahoo.com>
Date: Thu, 5 Apr 2012 10:25:54 +0200
Subject: [PATCH] Group based access restrictions to parcels require group
 membership, but not that this group is active for that user.

---
 .../CoreModules/World/Land/LandObject.cs      | 49 +++++++++----------
 1 file changed, 23 insertions(+), 26 deletions(-)

diff --git a/OpenSim/Region/CoreModules/World/Land/LandObject.cs b/OpenSim/Region/CoreModules/World/Land/LandObject.cs
index ced7b523b2..a7c7cc5234 100644
--- a/OpenSim/Region/CoreModules/World/Land/LandObject.cs
+++ b/OpenSim/Region/CoreModules/World/Land/LandObject.cs
@@ -424,37 +424,34 @@ namespace OpenSim.Region.CoreModules.World.Land
         {
             if (LandData.GroupID != UUID.Zero && (LandData.Flags & (uint)ParcelFlags.UseAccessGroup) == (uint)ParcelFlags.UseAccessGroup)
             {
-                ScenePresence sp;
-                if (!m_scene.TryGetScenePresence(avatar, out sp))
+                bool isMember;
+                if (m_groupMemberCache.TryGetValue(avatar, out isMember))
+                    return isMember;
+
+                IGroupsModule groupsModule = m_scene.RequestModuleInterface<IGroupsModule>();
+                if (groupsModule == null)
                 {
-                    bool isMember;
-                    if (m_groupMemberCache.TryGetValue(avatar, out isMember))
-                        return isMember;
-
-                    IGroupsModule groupsModule = m_scene.RequestModuleInterface<IGroupsModule>();
-                    if (groupsModule == null)
-                        return false;
-
-                    GroupMembershipData[] membership = groupsModule.GetMembershipData(avatar);
-                    if (membership == null || membership.Length == 0)
-                    {
-                        m_groupMemberCache.Add(avatar, false, m_groupMemberCacheTimeout);
-                        return false;
-                    }
-
-                    foreach (GroupMembershipData d in membership)
-                    {
-                        if (d.GroupID == LandData.GroupID)
-                        {
-                            m_groupMemberCache.Add(avatar, true, m_groupMemberCacheTimeout);
-                            return true;
-                        }
-                    }
                     m_groupMemberCache.Add(avatar, false, m_groupMemberCacheTimeout);
                     return false;
                 }
 
-                return sp.ControllingClient.IsGroupMember(LandData.GroupID);
+                GroupMembershipData[] membership = groupsModule.GetMembershipData(avatar);
+                if (membership == null || membership.Length == 0)
+                {
+                    m_groupMemberCache.Add(avatar, false, m_groupMemberCacheTimeout);
+                    return false;
+                }
+
+                foreach (GroupMembershipData d in membership)
+                {
+                    if (d.GroupID == LandData.GroupID)
+                    {
+                        m_groupMemberCache.Add(avatar, true, m_groupMemberCacheTimeout);
+                        return true;
+                    }
+                }
+                m_groupMemberCache.Add(avatar, false, m_groupMemberCacheTimeout);
+                return false;
             }
             return false;
         }