ogb912/opensim
1
0
Fork 0
mirror of https://github.com/opensim/opensim.git synced 2026-08-08 10:15:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

When casting strings to int, use double.Parse() as strings may be floats. With

Browse Source 
this commit, issue 1822 should be fixed.
This commit is contained in:
Mike Mazur
2008-07-28 07:46:53 +00:00
parent d959c65b91
commit f6fa4ada4e
4 changed files with 92 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
OpenSim/Tests/OpenSim/Region/ScriptEngine/Common/LSL_TypesTestLSLInteger.cs
View File

@@ -36,6 +36,7 @@ namespace OpenSim.Region.ScriptEngine.Common.Tests
public class LSL_TypesTestLSLInteger
{
private Dictionary<double, int> m_doubleIntSet;
private Dictionary<string, int> m_stringIntSet;
/// <summary>
/// Sets up dictionaries and arrays used in the tests.
@@ -51,10 +52,20 @@ namespace OpenSim.Region.ScriptEngine.Common.Tests
m_doubleIntSet.Add(-1.0, -1);
m_doubleIntSet.Add(999999999.0, 999999999);
m_doubleIntSet.Add(-99999999.0, -99999999);
m_stringIntSet = new Dictionary<string, int>();
m_stringIntSet.Add("2", 2);
m_stringIntSet.Add("-2", -2);
m_stringIntSet.Add("0", 0);
m_stringIntSet.Add("1", 1);
m_stringIntSet.Add("-1", -1);
m_stringIntSet.Add("123.9", 123);
m_stringIntSet.Add("999999999", 999999999);
m_stringIntSet.Add("-99999999", -99999999);
}
/// <summary>
/// Tests LSLInteger is correctly cast explicitly to LSLFloat.
/// Tests LSLFloat is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastLSLFloatToLSLInteger()
@@ -67,5 +78,35 @@ namespace OpenSim.Region.ScriptEngine.Common.Tests
Assert.AreEqual(testInteger.value, number.Value);
}
}
/// <summary>
/// Tests string is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastStringToLSLInteger()
{
LSL_Types.LSLInteger testInteger;
foreach (KeyValuePair<string, int> number in m_stringIntSet)
{
testInteger = (LSL_Types.LSLInteger) number.Key;
Assert.AreEqual(testInteger.value, number.Value);
}
}
/// <summary>
/// Tests LSLString is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastLSLStringToLSLInteger()
{
LSL_Types.LSLInteger testInteger;
foreach (KeyValuePair<string, int> number in m_stringIntSet)
{
testInteger = (LSL_Types.LSLInteger) new LSL_Types.LSLString(number.Key);
Assert.AreEqual(testInteger.value, number.Value);
}
}
}
}

43
OpenSim/Tests/OpenSim/Region/ScriptEngine/Shared/LSL_TypesTestLSLInteger.cs
View File

@@ -36,6 +36,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Tests
public class LSL_TypesTestLSLInteger
{
private Dictionary<double, int> m_doubleIntSet;
private Dictionary<string, int> m_stringIntSet;
/// <summary>
/// Sets up dictionaries and arrays used in the tests.
@@ -51,10 +52,20 @@ namespace OpenSim.Region.ScriptEngine.Shared.Tests
m_doubleIntSet.Add(-1.0, -1);
m_doubleIntSet.Add(999999999.0, 999999999);
m_doubleIntSet.Add(-99999999.0, -99999999);
m_stringIntSet = new Dictionary<string, int>();
m_stringIntSet.Add("2", 2);
m_stringIntSet.Add("-2", -2);
m_stringIntSet.Add("0", 0);
m_stringIntSet.Add("1", 1);
m_stringIntSet.Add("-1", -1);
m_stringIntSet.Add("123.9", 123);
m_stringIntSet.Add("999999999", 999999999);
m_stringIntSet.Add("-99999999", -99999999);
}
/// <summary>
/// Tests LSLInteger is correctly cast explicitly to LSLFloat.
/// Tests LSLFloat is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastLSLFloatToLSLInteger()
@@ -67,5 +78,35 @@ namespace OpenSim.Region.ScriptEngine.Shared.Tests
Assert.AreEqual(testInteger.value, number.Value);
}
}
/// <summary>
/// Tests string is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastStringToLSLInteger()
{
LSL_Types.LSLInteger testInteger;
foreach (KeyValuePair<string, int> number in m_stringIntSet)
{
testInteger = (LSL_Types.LSLInteger) number.Key;
Assert.AreEqual(testInteger.value, number.Value);
}
}
/// <summary>
/// Tests LSLString is correctly cast explicitly to LSLInteger.
/// </summary>
[Test]
public void TestExplicitCastLSLStringToLSLInteger()
{
LSL_Types.LSLInteger testInteger;
foreach (KeyValuePair<string, int> number in m_stringIntSet)
{
testInteger = (LSL_Types.LSLInteger) new LSL_Types.LSLString(number.Key);
Assert.AreEqual(testInteger.value, number.Value);
}
}
}
}