== string.Empty is .Lenght == 0

This commit is contained in:
UbitUmarov
2022-01-13 20:31:52 +00:00
parent 6595e3ae26
commit fbbcc1edd7
149 changed files with 261 additions and 264 deletions

View File

@@ -403,7 +403,7 @@ namespace OpenSim.Groups
// Here we always return true. The user has been added to the local group,
// independent of whether the remote operation succeeds or not
url = m_UserManagement.GetUserServerURL(uid, "GroupsServerURI");
if (url == string.Empty)
if (url.Length == 0)
{
reason = "You don't have an accessible groups server in your home world. You membership to this group in only within this grid.";
return true;

View File

@@ -66,7 +66,7 @@ namespace OpenSim.Groups
string homeURI = Util.GetConfigVarFromSections<string>(config, "HomeURI",
new string[] { "Startup", "Hypergrid", m_ConfigName}, string.Empty);
if (homeURI == string.Empty)
if (homeURI.Length == 0)
throw new Exception(String.Format("[Groups.RobustHGConnector]: please provide the HomeURI [Startup] or in section {0}", m_ConfigName));
IConfig cnf = config.Configs[m_ConfigName];
@@ -76,7 +76,7 @@ namespace OpenSim.Groups
if (im == null)
{
string imDll = cnf.GetString("OfflineIMService", string.Empty);
if (imDll == string.Empty)
if (imDll.Length == 0)
throw new Exception(String.Format("[Groups.RobustHGConnector]: please provide OfflineIMService in section {0}", m_ConfigName));
Object[] args = new Object[] { config };
@@ -86,7 +86,7 @@ namespace OpenSim.Groups
if (users == null)
{
string usersDll = cnf.GetString("UserAccountService", string.Empty);
if (usersDll == string.Empty)
if (usersDll.Length == 0)
throw new Exception(String.Format("[Groups.RobustHGConnector]: please provide UserAccountService in section {0}", m_ConfigName));
Object[] args = new Object[] { config };

View File

@@ -682,7 +682,7 @@ namespace OpenSim.Groups
ServerUtils.BuildQueryString(sendData),
m_Auth);
if (reply == string.Empty)
if (reply.Length == 0)
return null;
Dictionary<string, object> replyData = ServerUtils.ParseXmlResponse(

View File

@@ -47,7 +47,7 @@ namespace OpenSim.Groups
string connString = String.Empty;
string realm = "os_groups";
string usersRealm = "GridUser";
string configName = (cName == string.Empty) ? "Groups" : cName;
string configName = (cName.Length == 0) ? "Groups" : cName;
//
// Try reading the [DatabaseService] section, if it exists
@@ -55,9 +55,9 @@ namespace OpenSim.Groups
IConfig dbConfig = config.Configs["DatabaseService"];
if (dbConfig != null)
{
if (dllName == String.Empty)
if (dllName.Length == 0)
dllName = dbConfig.GetString("StorageProvider", String.Empty);
if (connString == String.Empty)
if (connString.Length == 0)
connString = dbConfig.GetString("ConnectionString", String.Empty);
}

View File

@@ -100,7 +100,7 @@ namespace OpenSim.Groups
return false;
}
if (grec.Data["Location"] == string.Empty)
if (grec.Data["Location"].Length == 0)
{
reason = "Cannot add proxy membership to non-proxy group";
return false;
@@ -234,7 +234,7 @@ namespace OpenSim.Groups
}
// check that the group is remote
if (grec.ServiceLocation == string.Empty)
if (grec.ServiceLocation.Length == 0)
{
m_log.DebugFormat("[Groups.HGGroupsService]: attempt at adding notice to local (non-proxy) group");
return false;

View File

@@ -63,7 +63,7 @@ namespace OpenSim.OfflineIM
m_Enabled = true;
string serviceLocation = cnf.GetString("OfflineMessageURL", string.Empty);
if (serviceLocation == string.Empty)
if (serviceLocation.Length == 0)
m_OfflineIMService = new OfflineIMService(config);
else
m_OfflineIMService = new OfflineIMServiceRemoteConnector(config);

View File

@@ -52,9 +52,9 @@ namespace OpenSim.OfflineIM
IConfig dbConfig = config.Configs["DatabaseService"];
if (dbConfig != null)
{
if (dllName == String.Empty)
if (dllName.Length == 0)
dllName = dbConfig.GetString("StorageProvider", String.Empty);
if (connString == String.Empty)
if (connString.Length == 0)
connString = dbConfig.GetString("ConnectionString", String.Empty);
}