Commit Graph

29 Commits

Author SHA1 Message Date
Justin Clarke Casey
8c0955321a * Refactor: Genericise request limit strategies and move to OpenSim.Framework.Communications.Limit 2008-03-24 18:21:06 +00:00
Justin Clarke Casey
6ce79a0f78 * Downgrade 'texture not found' message to DEBUG and stop putting out 'already dispatched' message completely temporarily
* I believe that if the Linden client has not started to receive a texture after 15 seconds, it re-requests it. 
* My hypothesis is that the texture packets are often still in the texture queue (esp. if the client has just cleared its cache), so another load of packets get added...
* If this is the cause, resolution is going to be rather complicated.
2008-03-22 19:15:01 +00:00
Justin Clarke Casey
936f961a53 * Reducing spam on console so we only notify once if we're dropping repeated requests for missing textures
* Also minor logic change so that we actually do retry missing texture requests (we weren't before)
2008-03-22 18:30:54 +00:00
Justin Clarke Casey
625e8f7700 * Minor log message change 2008-03-22 17:56:05 +00:00
Justin Clarke Casey
be83ac37f9 * Small adjust to last commit's logging so we only print out one warning when we start dropping requests 2008-03-21 20:19:43 +00:00
Justin Clarke Casey
45ea156804 * If a client session requests the same texture more than n times (currently n=5), we now drop the subsequent requests
* This may improve region memory usage
* This is a short-term response to a problem whereby some clients keep requesting the same texture even after we've sent it
* This treats the symptom rather than the cause.
* n can be adjusted by changing the constant at the top of UserTextureDownloadService if necessary
2008-03-21 19:16:29 +00:00
Justin Clarke Casey
93d05b8b1f * Print a warning every 20 times a client requests a texture that it should already have received
* The warning will be 
[USER TEXTURE DOWNLOAD SERVICE]: Received {0} requests for already dispatched texture {1} from client {2}
This is to see whether the texture packet queue memory leak is caused by clients continually re-requesting textures they should already have
2008-03-19 14:38:58 +00:00
Jeff Ames
47180080f0 Formatting cleanup. 2008-03-18 05:16:43 +00:00
Justin Clarke Casey
bbddc0dbe7 * Move missing texture request forward so that we don't actually ask the AssetCache for it if we know it's missing. 2008-03-17 21:44:54 +00:00
Justin Clarke Casey
cd1978b424 * Reduce the annoyingness of clients that continually request unfound textures (probably for some good reason) by dropping all subsequent requests after the first reply.
* Print out a console message every 20 tries rather than every single one.
* This weakens the problem but does not eliminate it
2008-03-17 17:30:01 +00:00
Justin Clarke Casey
42123770de * Add comments and slight corrections to ClientView.AgentTextureCached
* Reduce 'asset not found' console debug spam
2008-03-12 17:02:08 +00:00
Justin Clarke Casey
65862aacea * Start sending "ImageNotFound" packet back to the client if we can't find an image
* This might stop some client's constant requests for unfound textures, which is a candidate for the memory leak
* If a texture is not found then the "Image not found" texture will now be displayed clientside
* If it works, this should resolve mantis 676
* Non texture image requests do not receive this packet yet
* This will require a prebuild
2008-02-25 23:26:35 +00:00
Justin Clarke Casey
84c86c7bdd * Resolve Mantis 667 by not passing on textures with no actual data onto TextureSender 2008-02-25 19:10:02 +00:00
lbsa71
5b3897a4af * Caught HttpListenerException and swallowed if with output
* Moved Flush into Close since it's always done in that order.
* Minor renamings
* Reversed if for clarity
2008-02-25 15:36:24 +00:00
Justin Clarke Casey
b483faddf2 * Downgrade texture exception to a warning. 2008-02-22 21:13:23 +00:00
Jeff Ames
4a621d106c Remove a couple compiler warnings. 2008-02-21 00:50:09 +00:00
Justin Clarke Casey
7d7ad4dff2 * Only count download requests for assets which are not already waiting for data from the asset server
* This should stop the constant increase in the download requests statistics
* If you see stat numbers for download requests which are far from what you'd expect, please report
2008-02-20 20:23:03 +00:00
Jeff Ames
a8cfbbe963 Minor cleanup. 2008-02-20 18:38:20 +00:00
Justin Clarke Casey
877713999c * Report 'asset not found' situations back to UserTextureDownloadService
* This fixes some of the 'runaway downloads' problem but not all of it
* Also fix up logging messages so texture requests are reported as such rather than as assets
2008-02-20 17:34:10 +00:00
Justin Clarke Casey
48e085c774 * Add documentation
* The reason why pending downloads tick ever upwards is because missing assets are never signalled to the TextureSender
* Rectifying this is not straightfoward, but this will constitute the next patch.
* This does not explain the memory leak.
2008-02-19 23:42:30 +00:00
Jeff Ames
e207284fef Clean up logging calls using String.Format explicitly 2008-02-10 01:57:59 +00:00
Justin Clarke Casey
a50a8376d6 * In the most basic situations, ClientView and ScenePresence no longer leak memory
* However, I'm no longer sure they were even a big contributory factor (to this particular leak, there are other causes of other leaks).  I need better measurement techniques
* Removed most of my debugging gawp
2008-02-09 01:37:53 +00:00
Justin Clarke Casey
2dc94870aa Mostly debugging verbosity which I shall very shortly comment out.
Just want to try this out on windows quickly.
2008-02-09 00:14:34 +00:00
Jeff Ames
99844ee4c0 Added copyright statements. 2008-02-05 03:20:51 +00:00
lbsa71
b9dcb24175 * Removed unneeded and uneeded debug message 2008-01-08 20:28:31 +00:00
lbsa71
1337a3973d * changed form Debug to Verbose on Texture sending 2008-01-03 14:08:51 +00:00
lbsa71
7b062cefa2 * Added removal of TextureSenders and UserTextureDownloadService on agent leaving region. 2008-01-03 14:01:53 +00:00
Jeff Ames
119f9b0d80 Set svn:eol-style. 2008-01-03 13:44:52 +00:00
lbsa71
1d098aa84c * Some work on TextureDownloadModule
* fixed Cancel bug
2008-01-03 13:40:38 +00:00