Files
OpenSquawk/tests/shared/simControl.test.ts
itsrubberduck 3fe0ea5f8a feat(sim-control): wire frequency-sim-control command channel end-to-end
Implements the open items from docs/plans/2026-07-14-frequency-sim-control-design.md
§4/§"Offen für die Implementierungsphase": a per-bridge-token in-memory command
queue piggybacked on the existing telemetry channel, plus the client-side gate
and TTS confirmations.

- server/utils/simControlQueue.ts: TTL-based queue keyed by bridge token
  (enqueue → drainPending → resolve → drainResultsForClient).
- server/api/bridge/data.post.ts: response gains a `commands` field the
  bridge drains on its next telemetry POST.
- server/api/bridge/command.post.ts (new): client enqueues a parsed command,
  re-validated server-side via isValidSimControlCommand.
- server/api/bridge/command-result.post.ts (new): bridge reports ok/failed.
- server/api/bridge/live.get.ts: response gains `commandResults` so the
  client can announce outcomes.
- shared/utils/simControl.ts: wire types, isValidSimControlCommand, and
  simControlRejectionSpeech/simControlResultSpeech TTS phrasing.
- useLiveAtcSession.ts: parseSimControl() gated on bridgeConnected, wired in
  right after the local special cases and before the frequency check —
  matched commands never reach radioBackend.transmit().
- useSimBridgeSync.ts / live-atc.vue: bridgeToken threaded through, command
  results forwarded from the telemetry poll to TTS.

43 new tests (shared parser/validation/speech + server queue lifecycle/TTL).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-15 09:31:17 +02:00

279 lines
9.6 KiB
TypeScript

import { describe, it } from 'node:test'
import assert from 'node:assert/strict'
import {
parseSimControl,
isValidSimControlCommand,
simControlRejectionSpeech,
simControlResultSpeech,
} from '~~/shared/utils/simControl'
function expectCommand(input: string) {
const result = parseSimControl(input)
assert.equal(result.matched, true, `expected a command for "${input}", got ${JSON.stringify(result)}`)
return (result as Extract<ReturnType<typeof parseSimControl>, { matched: true }>).command
}
function expectNoMatch(input: string, reason?: string) {
const result = parseSimControl(input)
assert.equal(result.matched, false, `expected NO match for "${input}", got ${JSON.stringify(result)}`)
if (reason) {
assert.equal((result as Extract<ReturnType<typeof parseSimControl>, { matched: false }>).reason, reason)
}
}
describe('parseSimControl — approach setup', () => {
it('parses the canonical roadmap utterance (written form)', () => {
const cmd = expectCommand('set me up for an approach from 5000 ft to EDDF 07R')
assert.deepEqual(cmd, {
type: 'setup_approach',
airport_icao: 'EDDF',
runway: '07R',
altitude_ft: 5000,
})
})
it('parses the same utterance in fully spoken Whisper form', () => {
const cmd = expectCommand(
'set me up for an approach from five thousand feet to echo delta delta foxtrot zero seven right',
)
assert.deepEqual(cmd, {
type: 'setup_approach',
airport_icao: 'EDDF',
runway: '07R',
altitude_ft: 5000,
})
})
it('parses an approach without altitude ("runway 26 left" wording)', () => {
const cmd = expectCommand('set me up for an approach to EDDM runway 26 left')
assert.deepEqual(cmd, {
type: 'setup_approach',
airport_icao: 'EDDM',
runway: '26L',
})
})
it('parses a final with a distance ("5 mile final")', () => {
const cmd = expectCommand('put me on a 5 mile final for EDDF 25R')
assert.deepEqual(cmd, {
type: 'setup_approach',
airport_icao: 'EDDF',
runway: '25R',
final_distance_nm: 5,
})
})
it('parses a flight-level altitude in an approach setup', () => {
const cmd = expectCommand('set me up for an approach from flight level 100 to EDDL runway 23')
assert.deepEqual(cmd, {
type: 'setup_approach',
airport_icao: 'EDDL',
runway: '23',
altitude_ft: 10000,
})
})
it('rejects an approach altitude without a unit (ambiguous)', () => {
expectNoMatch('set me up for an approach from 5000 to EDDF 07R', 'missing_unit')
})
it('rejects an invalid runway number (40)', () => {
expectNoMatch('set me up for an approach to EDDF runway 40', 'invalid_runway')
})
it('rejects an approach without a runway', () => {
expectNoMatch('set me up for an approach to EDDF', 'missing_runway')
})
it('rejects an approach without an airport', () => {
expectNoMatch('set me up for an approach runway 25', 'missing_airport')
})
})
describe('parseSimControl — single-parameter changes', () => {
it('parses the roadmap altitude wording (bare number is OK — "altitude" names the unit context)', () => {
const cmd = expectCommand('change my altitude to 8000')
assert.deepEqual(cmd, { type: 'set_altitude', altitude_ft: 8000 })
})
it('parses an altitude given as flight level', () => {
const cmd = expectCommand('set my altitude to flight level 100')
assert.deepEqual(cmd, { type: 'set_altitude', altitude_ft: 10000 })
})
it('parses a heading change', () => {
const cmd = expectCommand('change my heading to 270')
assert.deepEqual(cmd, { type: 'set_heading', heading_deg: 270 })
})
it('parses a speed change with unit', () => {
const cmd = expectCommand('set my speed to 210 knots')
assert.deepEqual(cmd, { type: 'set_speed', ias_kts: 210 })
})
it('parses spoken digits ("change my heading to two seven zero")', () => {
const cmd = expectCommand('change my heading to two seven zero')
assert.deepEqual(cmd, { type: 'set_heading', heading_deg: 270 })
})
it('rejects a parameter change without a value', () => {
expectNoMatch('change my altitude', 'missing_value')
})
it('rejects an out-of-range altitude', () => {
expectNoMatch('change my altitude to 80000 feet', 'out_of_range')
})
it('rejects an out-of-range heading', () => {
expectNoMatch('change my heading to 370', 'out_of_range')
})
})
describe('parseSimControl — must NEVER match ATC dialogue', () => {
it('does not match a plain ATC readback ("descend to 5000 feet")', () => {
expectNoMatch('descend to 5000 feet', 'no_intent')
})
it('does not match a pilot request ("request descent to flight level 100")', () => {
expectNoMatch('request descent to flight level 100', 'no_intent')
})
it('does not match a clearance readback with runway and callsign', () => {
expectNoMatch('cleared to land runway 25R Lufthansa 359', 'no_intent')
})
it('does not match a squawk instruction ("set squawk 7000")', () => {
expectNoMatch('set squawk 7000', 'no_intent')
})
it('does not match an unanchored altitude mention ("set me up at 8000")', () => {
expectNoMatch('set me up at 8000')
})
})
describe('isValidSimControlCommand', () => {
it('accepts each command type at valid values', () => {
assert.equal(isValidSimControlCommand({ type: 'set_altitude', altitude_ft: 8000 }), true)
assert.equal(isValidSimControlCommand({ type: 'set_heading', heading_deg: 270 }), true)
assert.equal(isValidSimControlCommand({ type: 'set_speed', ias_kts: 210 }), true)
assert.equal(
isValidSimControlCommand({ type: 'setup_approach', airport_icao: 'EDDF', runway: '07R' }),
true,
)
assert.equal(
isValidSimControlCommand({
type: 'setup_approach',
airport_icao: 'EDDF',
runway: '25',
altitude_ft: 5000,
final_distance_nm: 5,
}),
true,
)
})
it('rejects out-of-range values', () => {
assert.equal(isValidSimControlCommand({ type: 'set_altitude', altitude_ft: 80000 }), false)
assert.equal(isValidSimControlCommand({ type: 'set_heading', heading_deg: 400 }), false)
assert.equal(isValidSimControlCommand({ type: 'set_speed', ias_kts: 10 }), false)
assert.equal(
isValidSimControlCommand({ type: 'setup_approach', airport_icao: 'EDDF', runway: '07R', altitude_ft: -1 }),
false,
)
})
it('rejects malformed shapes', () => {
assert.equal(isValidSimControlCommand(null), false)
assert.equal(isValidSimControlCommand({}), false)
assert.equal(isValidSimControlCommand({ type: 'teleport' }), false)
assert.equal(isValidSimControlCommand({ type: 'set_altitude', altitude_ft: '8000' }), false)
assert.equal(
isValidSimControlCommand({ type: 'setup_approach', airport_icao: 'eddf', runway: '07R' }),
false,
)
assert.equal(
isValidSimControlCommand({ type: 'setup_approach', airport_icao: 'EDDF', runway: '99' }),
false,
)
})
})
describe('simControlRejectionSpeech', () => {
it('has a distinct short reply for every non-no_intent reason', () => {
const reasons = [
'missing_value', 'missing_unit', 'out_of_range',
'invalid_runway', 'missing_runway', 'missing_airport',
] as const
const seen = new Set<string>()
for (const reason of reasons) {
const speech = simControlRejectionSpeech(reason)
assert.equal(typeof speech, 'string')
assert.ok(speech.length > 0)
seen.add(speech)
}
assert.equal(seen.size, reasons.length)
})
})
describe('simControlResultSpeech', () => {
it('confirms an approach setup with a final distance', () => {
const speech = simControlResultSpeech({
id: '1',
status: 'ok',
reason: null,
command: { type: 'setup_approach', airport_icao: 'EDDF', runway: '07R', final_distance_nm: 5 },
})
assert.equal(speech, 'repositioned, 5 mile final runway 07R')
})
it('confirms an approach setup without a final distance but with altitude', () => {
const speech = simControlResultSpeech({
id: '1',
status: 'ok',
reason: null,
command: { type: 'setup_approach', airport_icao: 'EDDF', runway: '07R', altitude_ft: 5000 },
})
assert.equal(speech, 'repositioned, runway 07R approach from 5000 feet')
})
it('confirms altitude/heading/speed changes', () => {
assert.equal(
simControlResultSpeech({ id: '1', status: 'ok', reason: null, command: { type: 'set_altitude', altitude_ft: 8000 } }),
'altitude set, 8000 feet',
)
assert.equal(
simControlResultSpeech({ id: '1', status: 'ok', reason: null, command: { type: 'set_heading', heading_deg: 270 } }),
'heading set, 270',
)
assert.equal(
simControlResultSpeech({ id: '1', status: 'ok', reason: null, command: { type: 'set_speed', ias_kts: 210 } }),
'speed set, 210 knots',
)
})
it('relays a failure reason from the bridge', () => {
const speech = simControlResultSpeech({
id: '1',
status: 'failed',
reason: 'aircraft on ground, airborne reposition refused',
command: { type: 'set_heading', heading_deg: 270 },
})
assert.equal(speech, 'unable, aircraft on ground, airborne reposition refused')
})
it('falls back to a generic failure line when no reason is given', () => {
const speech = simControlResultSpeech({
id: '1', status: 'failed', reason: null, command: { type: 'set_heading', heading_deg: 270 },
})
assert.equal(speech, 'unable to comply')
})
it('announces an expired (unanswered) command', () => {
const speech = simControlResultSpeech({
id: '1', status: 'expired', reason: null, command: { type: 'set_heading', heading_deg: 270 },
})
assert.equal(speech, 'bridge did not respond')
})
})