flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-04 16:56:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ref T210, cppcheck fixes

Browse Source 
a) 23	performance	useInitializationList	false	Variable 'm_artifactsPilotClient' is assigned in constructor body. Consider performing initialization in initialization list.
b) 33	performance	passedByValue	false	Function parameter 'il' should be passed by reference.

a) is clear, but b) seems to be wrong, hidden by "cppcheck-suppress"
This commit is contained in:
Klaus Basan
2017-12-20 04:16:01 +01:00
parent 1242c17e7a
commit 5a24e40312
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/blackmisc/db/updateinfo.cpp
View File

@@ -18,10 +18,11 @@ namespace BlackMisc
namespace Db
{
CUpdateInfo::CUpdateInfo(const CArtifactList &artifacts, const CDistributionList &distributions) :
m_artifactsPilotClient(artifacts.findByType(CArtifact::PilotClientInstaller)),
m_artifactsXsb(artifacts.findByType(CArtifact::XSwiftBus)),
m_distributions(distributions)
{
m_artifactsPilotClient = artifacts.findByType(CArtifact::PilotClientInstaller);
m_artifactsXsb = artifacts.findByType(CArtifact::XSwiftBus);
// void
}
CDistributionList CUpdateInfo::getDistributionsPilotClientForCurrentPlatform() const