Ref T239, removed "QTimer m_xxx { this };" pattern

* not in worker classes as parent might have a relevance there
* in UI classes it is useless

src/blackcore/simulatorcommon.h

@@ -265,7 +265,7 @@ namespace BlackCore
         bool m_blinkCycle = false;            //!< used for highlighting
         qint64 m_highlightEndTimeMsEpoch = 0; //!< end highlighting
         int m_timerCounter = 0;               //!< allows to calculate n seconds
-        QTimer m_oneSecondTimer { this };     //!< multi purpose timer
+        QTimer m_oneSecondTimer;              //!< multi purpose timer
         BlackMisc::Simulation::CSimulatorPluginInfo   m_simulatorPluginInfo;                //!< info object
         BlackMisc::Simulation::CSimulatedAircraftList m_highlightedAircraft;                //!< all other aircraft are to be ignored
         BlackMisc::Aviation::CCallsignSet             m_callsignsToBeRendered;              //!< callsigns which will be rendered

src/blackcore/vatsim/networkvatlib.h

@@ -242,10 +242,10 @@ namespace BlackCore
             BlackMisc::CDigestSignal m_dsSendTextMessage  { this, &CNetworkVatlib::emitConsolidatedTextMessages, 500, 10 };
             BlackMisc::Network::CTextMessageList m_textMessagesToConsolidate;
 
-            QTimer m_scheduledConfigUpdate { this };
-            QTimer m_processingTimer { this };
-            QTimer m_positionUpdateTimer { this };
-            QTimer m_interimPositionUpdateTimer { this };
+            QTimer m_scheduledConfigUpdate;
+            QTimer m_processingTimer;
+            QTimer m_positionUpdateTimer;
+            QTimer m_interimPositionUpdateTimer;
 
             static int const c_processingIntervalMsec = 100;            //!< interval for the processing timer
             static int const c_updatePostionIntervalMsec = 5000;        //!< interval for the position update timer (send our position to network)

src/blackgui/components/aircraftcomponent.h

@@ -86,7 +86,7 @@ namespace BlackGui
         private:
             QScopedPointer<Ui::CAircraftComponent> ui;
             BlackMisc::CSettingReadOnly<BlackGui::Settings::TViewUpdateSettings> m_settings { this, &CAircraftComponent::ps_settingsChanged }; //!< settings changed
-            QTimer m_updateTimer { this };
+            QTimer m_updateTimer;
         };
     } // ns
 } // ns

src/blackgui/components/aircraftpartshistory.h

@@ -39,7 +39,7 @@ namespace BlackGui
 
         private:
             QScopedPointer<Ui::CAircraftPartsHistory> ui;
-            QTimer m_timerUpdateHistory { this };
+            QTimer m_timerUpdateHistory;
             QTextDocument m_text { this };
             uint m_htmlHash = 0;
 

src/blackgui/components/atcstationcomponent.h

@@ -131,7 +131,7 @@ namespace BlackGui
             void settingsChanged();
 
             QScopedPointer<Ui::CAtcStationComponent> ui;
-            QTimer m_updateTimer { this };
+            QTimer m_updateTimer;
             QDateTime m_timestampLastReadOnlineStations; //!< stations read
             QDateTime m_timestampOnlineStationsChanged;  //!< stations marked as changed
             QDateTime m_timestampLastReadBookedStations; //!< stations read

src/blackgui/components/infobarwebreadersstatuscomponent.h

@@ -82,7 +82,7 @@ namespace BlackGui
             virtual void showConsolidationStatus(bool show);
 
         private:
-            QTimer m_timer { this }; //!< check timer
+            QTimer m_timer; //!< check timer
             BlackGui::CLedWidget *m_ledSwiftDb = nullptr;
             BlackGui::CLedWidget *m_ledDataReady = nullptr;
             BlackGui::CLedWidget *m_ledConsolidation = nullptr;

src/blackgui/components/logincomponent.h

@@ -211,7 +211,7 @@ namespace BlackGui
             const QIcon m_iconPlay {":/famfamfam/icons/famfamfam/icons/silk/control_play_blue.png"};
             const QIcon m_iconPause {":/famfamfam/icons/famfamfam/icons/silk/control_pause_blue.png"};
             const int LogoffIntervalSeconds = 20; //!< time before logoff
-            QTimer m_logoffCountdownTimer { this }; //!< timer for logoff countdown
+            QTimer m_logoffCountdownTimer; //!< timer for logoff countdown
             BlackMisc::CSettingReadOnly<BlackCore::Vatsim::TTrafficServers> m_otherTrafficNetworkServers { this, &CLoginComponent::reloadSettings };
             BlackMisc::CData<BlackMisc::Simulation::Data::TLastModel> m_lastAircraftModel { this }; //!< recently used aircraft model
             BlackMisc::CData<BlackMisc::Network::Data::TLastServer> m_lastServer { this }; //!< recently used server (VATSIM, other)

src/blackgui/components/mappingcomponent.h

@@ -151,7 +151,7 @@ namespace BlackGui
             static constexpr int OverlayMessageMs = 5000;
             QScopedPointer<Ui::CMappingComponent> ui;
             bool m_missedRenderedAircraftUpdate = true; //! Rendered aircraft need update
-            QTimer m_updateTimer { this };
+            QTimer m_updateTimer;
             BlackMisc::CTokenBucket m_bucket { 3, BlackMisc::PhysicalQuantities::CTime(5.0, BlackMisc::PhysicalQuantities::CTimeUnit::s()), 1};
             Views::CCheckBoxDelegate *m_currentMappingsViewDelegate = nullptr; //! checkbox in view
             BlackMisc::CIdentifier m_identifier { "MappingComponent", this };

src/blackgui/components/simulatorcomponent.h

@@ -90,7 +90,7 @@ namespace BlackGui
             void addOrUpdateLiveDataByName(const QString &name, const QString &value, BlackMisc::CIcons::IconIndex iconIndex);
 
             QScopedPointer<Ui::CSimulatorComponent> ui;
-            QTimer m_updateTimer { this };
+            QTimer m_updateTimer;
         };
     } // ns
 } // ns

src/blackgui/components/transpondermodeselector.h

@@ -77,7 +77,7 @@ namespace BlackGui
         private:
             BlackMisc::Aviation::CTransponder::TransponderMode m_currentMode = BlackMisc::Aviation::CTransponder::StateStandby;
             BlackMisc::Aviation::CTransponder::TransponderMode m_resetMode   = BlackMisc::Aviation::CTransponder::StateStandby;
-            QTimer m_resetTimer { this };
+            QTimer m_resetTimer;
         };
     } // ns
 } // ns

src/blackgui/components/usercomponent.h

@@ -66,7 +66,7 @@ namespace BlackGui
 
         private:
             QScopedPointer<Ui::CUserComponent> ui;
-            QTimer m_updateTimer { this };
+            QTimer m_updateTimer;
             BlackMisc::CSettingReadOnly<BlackGui::Settings::TViewUpdateSettings> m_settings { this, &CUserComponent::ps_settingsChanged };
         };
     }

src/blackgui/components/weathercomponent.h

@@ -77,7 +77,7 @@ namespace BlackGui
             QScopedPointer<Ui::CWeatherComponent> ui;
             QScopedPointer<CCoordinateDialog> m_coordinateDialog { new CCoordinateDialog(this) };
             QVector<BlackMisc::Weather::CWeatherScenario> m_weatherScenarios;
-            QTimer m_weatherUpdateTimer { this };
+            QTimer m_weatherUpdateTimer;
             BlackMisc::Geo::CCoordinateGeodetic m_lastOwnAircraftPosition;
             BlackMisc::CSetting<BlackMisc::Simulation::Settings::TSelectedWeatherScenario> m_weatherScenarioSetting { this };
             BlackCore::CActionBindings m_hotkeyBindings; //!< allow binding of hotkey

src/blackgui/editors/validationindicator.h

@@ -74,7 +74,7 @@ namespace BlackGui
             //! Set background color
             void setBackgroundColor(const QString colorName);
 
-            QTimer m_resetTimer { this};  //!< reset to neutral
+            QTimer m_resetTimer; //!< reset to neutral
             QString m_originalStyleSheet; //!< stored, to be able to reset
         };
     } // ns

src/blackgui/led.h

@@ -151,7 +151,7 @@ namespace BlackGui
         QString m_tooltipTriState = "tri-state"; //!< tooltip tri-state
         QString m_currentToolTip = "off";        //!< currently used tooltip
         QScopedPointer<QSvgRenderer> m_renderer; //!< Renderer
-        QTimer m_resetTimer { this };            //!< reset state
+        QTimer m_resetTimer;                     //!< reset state
 
         //! Init
         void init();

src/plugins/simulator/emulated/simulatoremulated.h

@@ -163,7 +163,7 @@ namespace BlackSimPlugin
             bool m_timeSyncronized = false;
             int m_countInterpolatedSituations = 0;
             int m_countInterpolatedParts = 0;
-            QTimer m_interpolatorFetchTimer { this }; //!< fetch data from interpolator
+            QTimer m_interpolatorFetchTimer; //!< fetch data from interpolator
             BlackMisc::PhysicalQuantities::CTime m_offsetTime;
             BlackMisc::Simulation::CSimulatedAircraft m_myAircraft;           //!< represents own aircraft of simulator
             BlackMisc::Simulation::CSimulatedAircraftList m_renderedAircraft; //!< represents remote aircraft in simulator

src/plugins/simulator/emulated/simulatoremulatedmonitordialog.h

@@ -107,7 +107,7 @@ namespace BlackSimPlugin
 
             QScopedPointer<Ui::CSimulatorEmulatedMonitorDialog> ui;
             CSimulatorEmulated *m_simulator = nullptr;
-            QTimer m_uiUpdateTimer { this };
+            QTimer m_uiUpdateTimer;
         };
     } // ns
 } // ns

src/plugins/simulator/fsxcommon/simulatorfsxcommon.h

@@ -365,7 +365,7 @@ namespace BlackSimPlugin
             CSimConnectObjects m_simConnectObjectsPositionAndPartsTraces; //!< position/parts received, but object not yet added, excluded, disabled etc.
             SIMCONNECT_DATA_REQUEST_ID m_requestIdSimData = static_cast<SIMCONNECT_DATA_REQUEST_ID>(RequestSimDataStart); //!< request id, use obtainRequestId() to get id
             BlackMisc::Simulation::CSimulatedAircraftList m_addPendingAircraft; //!< aircraft awaiting to be added
-            QTimer m_addPendingAircraftTimer { this }; //!< updating of aircraft awaiting to be added
+            QTimer m_addPendingAircraftTimer; //!< updating of aircraft awaiting to be added
         };
 
         //! Listener for FSX

src/swiftguistandard/swiftguistd.h

@@ -115,7 +115,7 @@ private:
     bool m_contextAudioAvailable   = false;    //!< audio context available?
     bool m_displayingDBusReconnect = false;    //!< currently displaying reconnect dialog
     bool m_dbDataLoading           = false;    //!< DB or shared data loading in progress
-    QTimer m_timerContextWatchdog { this };    //!< core available?
+    QTimer m_timerContextWatchdog;             //!< core available?
     BlackMisc::Simulation::CSimulatedAircraft m_ownAircraft; //!< own aircraft's state
 
     //! GUI status update