refactor: Fix clang-tidy warnings

This commit is contained in:
Lars Toenning
2025-03-24 08:49:05 +01:00
parent 20aa5d6f36
commit 999ce9a4d3
2 changed files with 26 additions and 27 deletions

View File

@@ -41,47 +41,47 @@ namespace swift::gui::models
using ObjectType = typename T::value_type;
//! Destructor
virtual ~CListModelBase() override {}
~CListModelBase() override = default;
//! \name Functions from QStandardItemModel
//! @{
//! \copydoc QStandardItemModel::data
virtual QVariant data(const QModelIndex &index, int role) const override;
QVariant data(const QModelIndex &index, int role) const override;
//! \copydoc QStandardItemModel::setData
virtual bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) final override;
bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) final;
//! \copydoc QStandardItemModel::mimeData
virtual QMimeData *mimeData(const QModelIndexList &indexes) const final override;
QMimeData *mimeData(const QModelIndexList &indexes) const final;
//! \copydoc QStandardItemModel::sort
virtual void sort(int column, Qt::SortOrder order) final override;
void sort(int column, Qt::SortOrder order) final;
//! \copydoc QStandardItemModel::rowCount
virtual int rowCount(const QModelIndex &parentIndex = QModelIndex()) const final override;
int rowCount(const QModelIndex &parentIndex = QModelIndex()) const final;
//! \copydoc QStandardItemModel::canDropMimeData
virtual bool canDropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column,
const QModelIndex &parent) const final override;
bool canDropMimeData(const QMimeData *data, Qt::DropAction action, int row, int column,
const QModelIndex &parent) const final;
//! \copydoc QStandardItemModel::dropMimeData
virtual bool dropMimeData(const QMimeData *mimeData, Qt::DropAction action, int row, int column,
const QModelIndex &parent) final override;
bool dropMimeData(const QMimeData *mimeData, Qt::DropAction action, int row, int column,
const QModelIndex &parent) final;
//! @}
//! \name Functions from CListModelBaseNonTemplate
//! @{
//! \copydoc swift::gui::models::CListModelBaseNonTemplate::toJson
virtual QJsonObject toJson(bool selectedOnly = false) const override;
QJsonObject toJson(bool selectedOnly = false) const override;
//! \copydoc swift::gui::models::CListModelBaseNonTemplate::toJsonString
virtual QString toJsonString(QJsonDocument::JsonFormat format = QJsonDocument::Indented,
bool selectedOnly = false) const override;
QString toJsonString(QJsonDocument::JsonFormat format = QJsonDocument::Indented,
bool selectedOnly = false) const override;
//! \copydoc swift::gui::models::CListModelBaseNonTemplate::isOrderable
virtual bool isOrderable() const override;
bool isOrderable() const override;
//! @}
//! Valid index (in range)
@@ -196,11 +196,11 @@ namespace swift::gui::models
//! @{
//! \copydoc swift::gui::models::CListModelBaseNonTemplate::onDataChanged
virtual void onDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomLeft,
const QVector<int> &roles) override;
void onDataChanged(const QModelIndex &topLeft, const QModelIndex &bottomLeft,
const QVector<int> &roles) override;
//! \copydoc swift::gui::models::CListModelBaseNonTemplate::onDataChanged
virtual void onChangedDigest() override;
void onChangedDigest() override;
//! @}
//! Update filtered container

View File

@@ -9,7 +9,6 @@
#include <QJsonDocument>
#include <QJsonObject>
#include <QModelIndex>
#include <QModelIndexList>
#include <QStandardItemModel>
#include <QString>
#include <QStringList>
@@ -42,33 +41,33 @@ namespace swift::gui::models
static constexpr int asyncThreshold = 50;
//! Destructor
virtual ~CListModelBaseNonTemplate() override {}
~CListModelBaseNonTemplate() override = default;
//! \name Functions from QStandardItemModel
//! @{
//! \copydoc QStandardItemModel::columnCount
virtual int columnCount(const QModelIndex &modelIndex = QModelIndex()) const final override;
int columnCount(const QModelIndex &modelIndex = QModelIndex()) const final;
//! \copydoc QStandardItemModel::headerData
virtual QVariant headerData(int section, Qt::Orientation orientation, int role) const final override;
QVariant headerData(int section, Qt::Orientation orientation, int role) const final;
//! \copydoc QStandardItemModel::index
virtual QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const final override;
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const final;
//! \copydoc QStandardItemModel::parent
virtual QModelIndex parent(const QModelIndex &child) const final override;
QModelIndex parent(const QModelIndex &child) const final;
//! \copydoc QStandardItemModel::flags
virtual Qt::ItemFlags flags(const QModelIndex &index) const final override;
Qt::ItemFlags flags(const QModelIndex &index) const final;
//! \copydoc QStandardItemModel::supportedDragActions
virtual Qt::DropActions supportedDragActions() const final override;
Qt::DropActions supportedDragActions() const final;
//! \copydoc QStandardItemModel::supportedDropActions
virtual Qt::DropActions supportedDropActions() const final override;
Qt::DropActions supportedDropActions() const final;
//! \copydoc QStandardItemModel::mimeTypes
virtual QStringList mimeTypes() const final override;
QStringList mimeTypes() const final;
//! @}
//! Column to property index