flightsimulatorplatfrom/pilotclient
1
0
Fork 0
mirror of https://github.com/swift-project/pilotclient.git synced 2026-04-04 08:36:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve logging when parsing VATSIM METARs

Browse Source 
refs #689
This commit is contained in:
Roland Winklmeier
2016-06-29 16:51:33 +02:00
parent 28ec2be1ca
commit a3fbbd7a67
1 changed files with 5 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/blackcore/vatsim/vatsimmetarreader.cpp
View File

@@ -119,39 +119,25 @@ namespace BlackCore
return; return;
} }
QString invalidMetars;
int invalidLineCount = 0;
CMetarList metars; CMetarList metars;
int invalidLines = 0;
QTextStream lineReader(&metarData); QTextStream lineReader(&metarData);
while (!lineReader.atEnd()) while (!lineReader.atEnd())
{ {
if (this->isAbandoned()) { return; } if (this->isAbandoned()) { return; }
QString line = lineReader.readLine(); QString line = lineReader.readLine();
CMetar metar = m_metarDecoder.decode(line); CMetar metar = m_metarDecoder.decode(line);
if (metar != CMetar()) if (metar != CMetar()) { metars.push_back(metar); }
{ else { invalidLines++; }
metars.push_back(metar);
}
else
{
invalidMetars += line;
invalidMetars += "\n";
invalidLineCount++;
}
} }
CLogMessage(this).debug() << "METAR statistic: " << metars.size() << "Metars ( invalid:" << invalidLines << ")";
{ {
QWriteLocker l(&m_lock); QWriteLocker l(&m_lock);
m_metars = metars; m_metars = metars;
} }
// I could use those for logging, etc.
Q_UNUSED(invalidMetars);
if (invalidLineCount > 0)
{
// Regular issue, log it, but do not show to user
CLogMessage(this).debug() << "Reading METARs failed for entries" << invalidLineCount;
}
emit metarsRead(metars); emit metarsRead(metars);
emit dataRead(CEntityFlags::MetarEntity, CEntityFlags::ReadFinished, metars.size()); emit dataRead(CEntityFlags::MetarEntity, CEntityFlags::ReadFinished, metars.size());
} }