Ref T189, no need to init const values over and over again

This commit is contained in:
Klaus Basan
2017-11-11 23:43:24 +01:00
parent 48adb52082
commit b08e281f85
2 changed files with 13 additions and 11 deletions

View File

@@ -770,16 +770,16 @@ namespace BlackCore
void CNetworkVatlib::broadcastAircraftConfig(const QJsonObject &config)
{
QString data = QJsonDocument(QJsonObject { { "config", config } }).toJson(QJsonDocument::Compact);
data = convertToUnicodeEscaped(data);
Vat_SendAircraftConfigBroadcast(m_net.data(), toFSD(data));
static const QString dataStr = convertToUnicodeEscaped(QJsonDocument(QJsonObject { { "config", config } }).toJson(QJsonDocument::Compact));
static const QByteArray data(toFSD(dataStr));
Vat_SendAircraftConfigBroadcast(m_net.data(), data);
}
void CNetworkVatlib::sendAircraftConfigQuery(const CCallsign &callsign)
{
const QJsonDocument doc(JsonPackets::aircraftConfigRequest());
const QString data { doc.toJson(QJsonDocument::Compact) };
Vat_SendAircraftConfig(m_net.data(), toFSD(callsign), toFSD(data));
static const QString dataStr { QJsonDocument(JsonPackets::aircraftConfigRequest()).toJson(QJsonDocument::Compact) };
static const QByteArray data(toFSD(dataStr));
Vat_SendAircraftConfig(m_net.data(), toFSD(callsign), data);
}
/********************************** * * * * * * * * * * * * * * * * * * * ************************************/
@@ -1163,9 +1163,10 @@ namespace BlackCore
CLogMessage(static_cast<CNetworkVatlib *>(nullptr)).error(message);
}
QJsonObject CNetworkVatlib::JsonPackets::aircraftConfigRequest()
const QJsonObject &CNetworkVatlib::JsonPackets::aircraftConfigRequest()
{
return { { "request", "full" } };
static const QJsonObject jsonObject{ { "request", "full" } };
return jsonObject;
}
} // namespace
} // namespace

View File

@@ -179,14 +179,15 @@ namespace BlackCore
static void networkLogHandler(SeverityLevel severity, const char *message);
void sendCustomPacket(const BlackMisc::Aviation::CCallsign &callsign, const QString &packetId, const QStringList &data);
inline QString defaultModelString()
static const QString &defaultModelString()
{
return QStringLiteral("Cessna Skyhawk 172SP");
static const QString dm("Cessna Skyhawk 172SP");
return dm;
}
struct JsonPackets
{
static QJsonObject aircraftConfigRequest();
static const QJsonObject &aircraftConfigRequest();
};
void process();