Commit Graph

180 Commits

Author SHA1 Message Date
Justin Clarke Casey
42123770de * Add comments and slight corrections to ClientView.AgentTextureCached
* Reduce 'asset not found' console debug spam
2008-03-12 17:02:08 +00:00
Justin Clarke Casey
956f7cb4f9 * Very minor error message change in GridAssetClient 2008-03-11 17:55:49 +00:00
MW
70ad5604cd disabled AssetDownloadModule and re-enabled the asset download code in the asset cache, until it can be seen if the module was the cause of some new problems that seem like they might be related to assets. I'll look into this more tomorrow. 2008-02-27 22:47:33 +00:00
MW
2c65c2da90 small fix in the showstate data in AssetCache to reflect that now some functions are no longer in AssetCache 2008-02-27 21:32:01 +00:00
MW
e978d00914 After seeing sdague do his happy dance over trunk working "the best he has ever seen". I'm not sure I should be doing this commit, but oh well.
So anyway, it moves the Asset downloading (packet sending) to a module (AssetDownloadModule). 
So now at last, AssetCache should be just dealing with fetching assets from the asset server and caching them.
2008-02-27 21:11:01 +00:00
MW
aac7c1dda5 another attempt at fixing asset lockups 2008-02-27 16:20:45 +00:00
MW
a9ae5ab840 Hopefully fixed the bug that was causing a lot of the freezing. Which was happening due to locks in the AssetCache and Texturedownload module. Where the thread from the Asset thread would be take a lock on a list in the asset cache and then try to call the Callback into the texturedownload module and hit a lock in there which was held by a ClientView thread- which at the same time would be trying to request another texture from the cache and be hitting the lock in there held by the IClientAPI. The result each thread waiting for the other one to release a lock. And as one of those was the ClientView process packet thread. No more packets from that client could be processed. For now I've made a copy of the list in AssetCache so that it can release the lock. I'm doing more work on assets (moving the client asset downloading to a module ), so will hopefully change this into a better method once I've cleaned over things up a bit. 2008-02-27 14:40:30 +00:00
Justin Clarke Casey
65862aacea * Start sending "ImageNotFound" packet back to the client if we can't find an image
* This might stop some client's constant requests for unfound textures, which is a candidate for the memory leak
* If a texture is not found then the "Image not found" texture will now be displayed clientside
* If it works, this should resolve mantis 676
* Non texture image requests do not receive this packet yet
* This will require a prebuild
2008-02-25 23:26:35 +00:00
Justin Clarke Casey
f95ad65189 * Improve alignment of packet queue stats headigns
* Correct asset cache stats table heading
* Correct spelling mistake in AssetCache (thanks ChrisD!)
2008-02-22 23:15:00 +00:00
Justin Clarke Casey
fed46ba6a7 * Winnow the debug and info messages associated with stat fetching
* As such, only a request for a non cached asset, the response and failures show up now.
* I know lbsa71 only put these in not long ago, so if they are really still required, I think we should think whether we can move the default log4net level off 'Debug'
2008-02-22 22:54:50 +00:00
Tedd Hansen
7102ac7769 "threads" command now works. I've added manual tracking of threads (only if compiled in DEBUG mode)... Its ugly and even requires a separate thread to track the treads, but it will be very valuable in debugging. 2008-02-21 10:43:24 +00:00
Justin Clarke Casey
b0c5ef0b68 * Eliminate AssetCache.CopyAsset()
* Resolve a bad logic bug in AssetCache.GetAsset()
* This may make some asset related things work better (possibly getting main map images will now be improved).
2008-02-20 23:21:51 +00:00
Justin Clarke Casey
7d7ad4dff2 * Only count download requests for assets which are not already waiting for data from the asset server
* This should stop the constant increase in the download requests statistics
* If you see stat numbers for download requests which are far from what you'd expect, please report
2008-02-20 20:23:03 +00:00
Justin Clarke Casey
f3190810d3 * Properly guard removal of asset request lists on AssetCache.AssetNotFound (my own bug) 2008-02-20 19:13:59 +00:00
Justin Clarke Casey
53d5aeec24 * Remove unused texture dictionaries from AssetCache
* Add documentation to AssetCache
2008-02-20 19:02:04 +00:00
Jeff Ames
a8cfbbe963 Minor cleanup. 2008-02-20 18:38:20 +00:00
Justin Clarke Casey
c66b5a9e71 Report command string on ConsoleBase.RunCommand exception 2008-02-20 17:54:14 +00:00
Justin Clarke Casey
877713999c * Report 'asset not found' situations back to UserTextureDownloadService
* This fixes some of the 'runaway downloads' problem but not all of it
* Also fix up logging messages so texture requests are reported as such rather than as assets
2008-02-20 17:34:10 +00:00
lbsa71
4c6e5a5090 * re-enabled AssetNotFound code
* turned script asset fetching asynchronous
2008-02-20 13:11:19 +00:00
lbsa71
9be5f9d6cc * Fixed xml loading bug (the xml was scheduled for update before added to a scene)
* Fixed ClickAction situation on the same note (properties shouldn't cause big changes)
* Added some more debug output to AssetCache
2008-02-20 09:38:45 +00:00
Tedd Hansen
47c909ca0a Playing "Name that thread". Adding names and isbackground=true to all threads so it will be easier to debug. 2008-02-19 12:02:53 +00:00
MW
b618802e53 Moved the AgentAssetTransactionsManager (and AgentAssetTransactions) out of CommsManager and into a module (AgentAgentTransactionModule), still needs cleaning up though.
But its one more thing out of the CommsManager. One day we will kill the CommsManager!
2008-02-16 13:01:42 +00:00
Jeff Ames
001ce95e4c Clean up more unnecessary String.Format calls 2008-02-13 03:38:18 +00:00
Justin Clarke Casey
a1a206cb05 * Clean up LIBRARY INVENTORY messages 2008-02-13 02:43:41 +00:00
Justin Clarke Casey
45638cc141 Commenting and a spelling correction 2008-02-13 01:04:27 +00:00
Justin Clarke Casey
1677bde480 * Clean up the agent's asset transactions when it is removed from the scene
* This may or may not help with the memory leak, need to assess
2008-02-13 00:52:49 +00:00
Justin Clarke Casey
365cf8e455 * Refactor: Move last commit's refactor back to AgentAssetTransactionsManager
* Push asset update (invoked when clothing is altered) down into AgentAssetTransactions from Scene.Inventory.cs to join others
* I've tested that clothing creation and update still works, but please let me know if it suddently breaks for you.
* Add/correct comments
2008-02-13 00:30:51 +00:00
Justin Clarke Casey
2018cf312b Refactor: factor a method out of AgentAssetTransactionsManager 2008-02-12 22:41:57 +00:00
Justin Clarke Casey
c0211c1ca2 * Add missing locking to mysql inventory plugin
* Should resolve mantis 542
2008-02-12 22:24:12 +00:00
Justin Clarke Casey
6a3455a98c * Refactoring: Rename AssetTransactions.cs and AssetTransactionsManager and align classes with file names
* Small amount of ndoc
* This will probably require a prebuild and nant clean
2008-02-12 18:15:54 +00:00
MW
7bbb9a08cb Re-enabled Inventory creation of body parts 2008-02-11 20:54:46 +00:00
Jeff Ames
e207284fef Clean up logging calls using String.Format explicitly 2008-02-10 01:57:59 +00:00
lbsa71
e9eaf8e949 * fixed typo. thanks, nebadon! 2008-02-09 22:26:28 +00:00
lbsa71
7486762aa0 * Refactored some asset code and in the process uncovered a bug; now, I think first transfer of asset should start faster. 2008-02-09 22:23:36 +00:00
lbsa71
0b0bb28fd5 * added count of texture data bytes and asset bytes 2008-02-09 21:50:45 +00:00
lbsa71
e2ed5bf6b9 * Added count of temporary assets 2008-02-09 21:25:34 +00:00
lbsa71
176a1fe382 * added two new commands (for debug/disaster recovery)
'show assets' shows the current state of the asset cache (number of cached assets, requests, et c)
  'clear-assets' forcibly re-initializes the asset cache thereby freeing all cached items.

'clear-assets' is not to be used lightly, as it probably introduces mem inconsistencies and doubling up of textures.
2008-02-09 21:17:47 +00:00
Justin Clarke Casey
d546859bc1 * Change logger to handle [<entry>] where <entry> contains non alphabetic characters
* Change logger to not print extra line if [<entry>] <text> like string is not logged
* Remove more of my previous chatty debugging statements
2008-02-09 01:53:57 +00:00
Justin Clarke Casey
16f8f19a54 * Stop asset transactions hanging around after they've completed
* Still not enough to solve the memory leak, though hopefully this is another step on the path
* All these changes are pretty temporary - this will be addressed with a more fundamental refactor in the future
2008-02-08 23:42:19 +00:00
Justin Clarke Casey
f05f583613 Still chasing logout memory leak. Putting in small changes and temporary light verbosity to this end 2008-02-08 22:39:08 +00:00
Sean Dague
598c5a95d9 fix the issue found on IRC this morning. The logging call was mistructured
so threw and exception when attempting to log that we missed an asset and
were waiting for it.
2008-02-08 15:29:53 +00:00
Jeff Ames
6ed5283bc0 Converted logging to use log4net.
Changed LogBase to ConsoleBase, which handles console I/O.
This is mostly an in-place conversion, so lots of refactoring can still be done.
2008-02-05 19:44:27 +00:00
MW
755ad9e3e0 First part of avatar persistence, currently only really works in standalone mode (with accounts_authenticate set to true), it also only currently has a mysql database connector. (sqlite one will follow soon). It also uses the tribalmedia database system, so this needs checking to see if the old problems with mono have been fixed.
To use, see the appearance section in opensim.ini.example, set "persist = true", then add the correct connection string for your database.(see mysql-AvatarAppearance.sql in share folder for a example of the table mysql table structure).
This could possible be used in a very small grid, but would mean each region server would need to connect to the same mysql database. 
But the work to move the code to one of the grid servers shouldn't be too much.
2008-02-04 12:04:02 +00:00
Adam Frisby
35a8c95e1d * Lowered maxchunk from 1500 bytes to 1250 bytes to make sure packets fit below the average maximum MTU of 1500 bytes inc. header. Thanks Alex for reporting this. 2008-02-04 10:28:39 +00:00
Adam Frisby
d12f253cca * Default inventory permissions patch (#444), courtesy of alex_carnell -- thanks! 2008-02-04 10:24:37 +00:00
Justin Clarke Casey
a4bf98f4ba * Add asset/texture cache statistics to region server console
* You can type 'stats' at the REGION# prompt to get this information in grid or standalone mode
* Don't take these numbers as gospel yet, since for some reason textures displayed from inventory which require downloading from the server are being recorded as assets 
rather than textures
* But I don't have any reason to believe they aren't broadly accurate.
* I've put these in so I can tell whether the high memory usage on regions is down to the asset/texture cache
* This will require a prebuild
* DEV: Only adds needed to be implemented since, as far as I can tell, assets cached are currently never released.  For my part, seeing large cache memory numbers will 
provoke me to think about doing something about this.
* DEV: Now switched to using a singleton to get the stats reporters rather than threading the object through various layers
* DEV: Will refactor the other server stats reporters to do this in one of the next commits
2008-01-31 00:42:31 +00:00
Adam Frisby
b25f9f322c * Mother of all commits:
* Cleaned up copyright notices in AssemblyInfo.cs's
* Added Copyright headers to a bunch of files missing them
* Replaced several common string instances with a static constant to prevent reallocation of the same strings thousands of times. "" -> String.Empty is the first such candidate.
2008-01-15 02:09:55 +00:00
Jeff Ames
5a6fd21a2c Whitespace cleanup. 2008-01-10 06:49:29 +00:00
lbsa71
c0252073d0 * removed another superfluous debug message 2008-01-09 09:31:07 +00:00
Brian McBee
bafdac7874 dump_assets_to_file=true will now cause the asset to go into a UserAssets subdirectory of bin instead of cluttering up your bin directory (Thanks CharlieO!) 2008-01-09 03:57:53 +00:00