Commit Graph

4640 Commits

Author SHA1 Message Date
Mathew Sutcliffe
55b7a519d1 Fixed missing override keywords
Summary: Fixed GCC 6.3 missing override warnings.

Reviewers: #swift_pilot_client, rwinklmeier

Reviewed By: #swift_pilot_client, rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D27
2017-06-23 18:18:05 +01:00
Mathew Sutcliffe
de5cb56525 Fixed strict aliasing warning
Summary:
Use `noquote` method instead of relying on undefined behaviour. This fixes a warning in GCC 6.3.

`noquote` method was added in Qt 5.4.

Reviewers: #swift_pilot_client, kbasan

Reviewed By: kbasan

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D26
2017-06-23 18:17:56 +01:00
Mathew Sutcliffe
87aa25a351 Bump version number again. 2017-06-20 18:01:29 +01:00
Klaus Basan
e07e87cd9f Ref T34, review item 2017-06-18 22:51:12 +02:00
Klaus Basan
a7e5b70633 Unified parameter nane 2017-06-18 22:51:11 +02:00
Klaus Basan
a8eae0ea55 Some UI formatting / padding 2017-06-18 22:51:10 +02:00
Klaus Basan
2746b0a5f9 Improved VATSIM datafile parsing
* removed empty split value at end
* some formatting
* columns to lower case at 1st parsing, not always
2017-06-18 22:51:09 +02:00
Klaus Basan
d4e240ca1b Ref T45, Ref T28 set default consolidation time
(which also is supposed to solve timeout issue)
2017-06-18 22:51:09 +02:00
Klaus Basan
334adbf02d Ref T70, filters and model
* added model descriptions in view model
* filtering for family and all 3 descriptions
* completers for filter fields
2017-06-18 22:51:08 +02:00
Klaus Basan
63598a6a4e Ref T70, utility functions
* remove duplicates
* 3 model descriptions
2017-06-18 22:51:07 +02:00
Klaus Basan
96c27c1c5b Ref T80, improved completer
* no invalid combined codes in list
* sort by rank
* refresh completer strings when new codes are added
2017-06-18 22:51:06 +02:00
Klaus Basan
fba521ecd5 Formatting 2017-06-18 22:51:06 +02:00
Klaus Basan
eecbcbf914 Ref T80, remove invalid combined codes 2017-06-18 22:51:05 +02:00
Klaus Basan
699a8d0f9f Ref T82, removed add button for servers, only save
* save will add a new server when not already existing
* when saved with same name, it will override values
* default values for FSD setup
* adjusted validation
2017-06-18 22:51:04 +02:00
Klaus Basan
76e1a06c44 Ref T82, allow to sort by severity 2017-06-18 22:51:03 +02:00
Klaus Basan
e45ad3b7e9 Fix missing arg 2017-06-18 22:51:03 +02:00
Klaus Basan
7a75413fc1 Ref T84, fix for better readibility of news / hyperlinks
* adjust palette to change link color: hardcoded, but no other way per stylesheet
* stylesheet fix to avoid black font in table view (CTRL S)

Remark:
Currently we just display the blog page as news, which is not correctly formatted, but somehow works.
In the future we might use a tailored HTML page for that.
2017-06-18 22:51:02 +02:00
Roland Winklmeier
79556260bd Remove QtConcurrent from list of Qt modules
Summary:
QtConcurrent isn't used any longer in swift code, so we can remove it
from the list of enabled modules. Disabling it causes the QtConcurrent
header path to be removed from the include paths and we no longer
unnecessarily link against it.

Reviewers: msutcliffe

Reviewed By: msutcliffe

Subscribers: jenkins

Differential Revision: https://dev.swift-project.org/D25
2017-06-09 12:29:59 +02:00
Roland Winklmeier
5d1b5dba38 Allow to select server type in FSD settings
Summary:
With this change the server type is a dynamic setting per server and
replaces the hardcoded global server type in CNetworkVatlib. This allows
the user to select the server type in settings ui and configures
the vatlib session accordingly.
This also removes the command line argument to set the server type since
it doesn't make sense anymore.

Reviewers: msutcliffe

Reviewed By: msutcliffe

Subscribers: jenkins

Differential Revision: https://dev.swift-project.org/D24
2017-06-09 12:27:58 +02:00
Roland Winklmeier
f1f7ee4709 Build with VATSIM support per default with hardened vatlib
The hardened vatlib requires to use server type VATSIM (which configures
the VATSIM protocol in vatlib) to connect to VATSIM servers. Using
any other server type will from now on fail to connect to VATSIM.
Since unit tests regularly run tests against the server running on VATGER, this has to be enabled
change the default server type to VATSIM by enabling SwiftVatsimSupport.
2017-05-30 13:03:33 +02:00
Mathew Sutcliffe
2509fb9d2e Fatal message should generate a messagebox on Windows.
Qt already does this in debug builds, so this just makes release builds consistent.
2017-05-15 22:31:39 +01:00
Mathew Sutcliffe
ce6d0d8f1e A failed BLACK_VERIFY will generate a Crashpad crash report.
Using noinline to make sure the call to failedVerify is visible in the stack trace.
2017-05-15 22:31:38 +01:00
Mathew Sutcliffe
5b8d76c06c Always disconnect CNetworkVatlib when shutting down. 2017-05-15 22:31:36 +01:00
Mathew Sutcliffe
04af0e8af3 Bump version number. 2017-05-14 17:21:40 +01:00
Mathew Sutcliffe
bc80fd3bd5 [feature][XPlane] Set own aircraft model string when own aircraft changes.
Summary:
Refactored parts of CAircraftModelLoaderXPlane::parseFlyableAirplanes into static method extractAcfProperties that can be called by xswiftbus.

Used extractAcfProperties in xswiftbus to provide the model string to the driver. Implemented CSimulatorXPlane::ps_emitOwnAircraftModelChanged.

Implements T74.

Reviewers: rwinklmeier

Reviewed By: rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D23
2017-05-14 17:21:39 +01:00
Mathew Sutcliffe
50b8fbe8fe [bug][Windows][Installer][DBus] Install session.conf in the correct location where dbus-daemon will look for it.
Summary:
On Windows, libdbus will spawn dbus-daemon when swift tries to connect to the session bus.

The daemon looks for session.conf in the share directory.
This patch ensures session.conf is installed in that directory.

Fixes T79.

Reviewers: rwinklmeier

Reviewed By: rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Maniphest Tasks: T79

Differential Revision: https://dev.swift-project.org/D22
2017-05-14 17:21:37 +01:00
Mathew Sutcliffe
ff2687fbe9 T66 Check whether it is safe to abandon the worker. 2017-05-14 17:21:36 +01:00
Mathew Sutcliffe
98e67860bc T66 Tidying up CBackgroundDataUpdater startup and shutdown
by overriding the CContinuousWorker virtual methods that exist for this purpose.
2017-05-14 17:21:35 +01:00
Mathew Sutcliffe
41ff563e19 T66 A new smart pointer for managing a CContinuousWorker subclass instance.
Owns the worker before it starts, when ownership is transferred to the thread.
2017-05-14 17:21:34 +01:00
Mathew Sutcliffe
ca81c65eae T66 CContinuousWorker tracks whether it has been started,
and when starting checks that it was not already started.
2017-05-14 17:21:33 +01:00
Mathew Sutcliffe
fd649c0b5c T73 Added virtual final destructors in CMeasurementUnit derived classes.
This fixes the GCC warning "deleting polymorphic object with non-virtual destructor".
They are marked final so the virtual dispatch can be optimized out, because they don't need to be overridden.
2017-05-14 17:21:31 +01:00
Mathew Sutcliffe
07ec7e6bc1 T73 Pass units by value.
Class types which are trivial to copy should be passed by value.
2017-05-14 17:21:30 +01:00
Mathew Sutcliffe
c8d78ada65 T73 Flyweight pattern based on pimpl, to reduce CMeasurementUnit memory usage.
* All members of CMeasurementUnit moved into nested pimpl class Data.
* CMeasurementUnit has only one member: a pointer to a const Data.
* Static const CMeasurementUnits replaced with static const Datas.
* Each CMeasurementUnit singleton method returns by-value a CMeasurementUnit containing a pointer to a static const Data.
* Means CMeasurementUnit is trivial to copy because we never copy the pimpl members.
** Works because the available units are fixed at compile time so we never need to create novel units at runtime.
2017-05-14 17:21:23 +01:00
Mathew Sutcliffe
fef2bc528e T73 Enabled for constexpr, to take advantage of constant-initialization.
* CMeasurementUnit and every one of its members is a literal type.
** This requires using QLatin1String instead of QString.
* Every static const CMeasurementUnit is static constexpr.
** This means they are initialized at compile time, no runtime initialization needed.
2017-05-14 17:13:40 +01:00
Mathew Sutcliffe
5e4349bba6 T73 Style. 2017-05-14 15:08:04 +01:00
Mathew Sutcliffe
48482d8d1e T73 CMeasurementUnit converter strategy based on function pointers.
Because function pointers are literal types, so they can be constexpr.
2017-05-14 15:08:03 +01:00
Mathew Sutcliffe
895190c4d0 T73 Fixed non-threadsafe static initialization. 2017-05-14 15:08:01 +01:00
Roland Winklmeier
8bf9296d51 Remove argument 'self' from static method fix_library_name
Summary:
fix_library_name is a static method and therefore does not accept
argument 'self'.

Reviewers: kbasan, msutcliffe

Reviewed By: msutcliffe

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D21
2017-05-14 15:08:00 +01:00
Mathew Sutcliffe
e848459ccb Avoiding QRegularExpression for simple stuff [follow-up D11]
Summary: Fixing a snag I noticed while reviewing D11. There is no need to use a regex for such a simple thing as removing `[^A-Z]`. Some other minor optimizations in the same function.

Reviewers: rwinklmeier, kbasan

Reviewed By: rwinklmeier

Subscribers: jenkins

Tags: #swift_pilot_client

Differential Revision: https://dev.swift-project.org/D20
2017-05-14 15:04:32 +01:00
Mathew Sutcliffe
a89e042ff8 Prevent inserting default-constructed elements in CSimulatorFsxCommon::m_simConnectObjects.
Hopefully this fixes null pointer dereference of CSimConnectObject::m_interpolator.
2017-05-14 15:04:31 +01:00
Mathew Sutcliffe
91341890ec Use a blocking queued connection to CLogHandler::logLocalMessage
when logging a fatal message from a worker thread.
Hopefully this will allow assert messages to be recorded in the logs.
2017-05-11 17:39:42 +01:00
Mathew Sutcliffe
f34c48cf6c T79 Improved log messages. 2017-05-11 16:37:54 +01:00
Klaus Basan
57b39dcd37 Unified setting key 2017-05-09 19:13:58 +02:00
Klaus Basan
9b8afdf499 Ref T78, setting and dialog "do not show again"
Applies to automatic update info check
2017-05-09 19:13:57 +02:00
Klaus Basan
0af6a372e3 UI stash text improved and stash shortcuts 2017-05-09 19:13:56 +02:00
Klaus Basan
43bd700687 Ref T63, remember directory 2017-05-09 19:13:56 +02:00
Klaus Basan
a4100d7efa Ref T77, tooltip for models (HTML Summary) 2017-05-09 19:13:54 +02:00
Klaus Basan
afbb87298f Ref T77, prefix for getDbKeyAsStringInParentheses 2017-05-09 19:13:53 +02:00
Klaus Basan
ba85e3851b Ref T75, filter aircraft model by id 2017-05-09 19:13:52 +02:00
Klaus Basan
7df685bbda Ref T75, filter livery by id 2017-05-09 19:13:51 +02:00