ogb912/micromdm
1
0
Fork 0
mirror of https://github.com/micromdm/micromdm/ synced 2026-08-10 19:46:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

GET to POST and POST to PUT for v1/apps endpoint (#525)

Browse Source 
Changed GET to POST for "get apps" as a GET with a request body is not preferred.

Changed POST to PUT for "upload apps" as POST is now used for "get apps".
This commit is contained in:
jenjac
2018-10-10 12:06:24 -05:00
committed by Victor Vrantchan
parent 323c05b230
commit 0ecc2d9f24
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platform/appstore/client.go
View File

@@ -19,7 +19,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp
var appUploadEndpoint endpoint.Endpoint
{
appUploadEndpoint = httptransport.NewClient(
"POST",
"PUT",
httputil.CopyURL(u, "/v1/apps"),
httputil.EncodeRequestWithToken(token, encodeUploadAppRequest),
decodeUploadAppResponse,
@@ -30,7 +30,7 @@ func NewHTTPClient(instance, token string, logger log.Logger, opts ...httptransp
var listAppsEndpoint endpoint.Endpoint
{
listAppsEndpoint = httptransport.NewClient(
"GET",
"POST",
httputil.CopyURL(u, "/v1/apps"),
httputil.EncodeRequestWithToken(token, httptransport.EncodeJSONRequest),
decodeListAppsResponse,

8
platform/appstore/server.go
View File

@@ -21,17 +21,17 @@ func MakeServerEndpoints(s Service, outer endpoint.Middleware, others ...endpoin
}
func RegisterHTTPHandlers(r *mux.Router, e Endpoints, options ...httptransport.ServerOption) {
// POST /v1/apps upload an app to the server
// GET /v1/apps list apps managed by the server
// PUT /v1/apps upload an app to the server
// POST /v1/apps list apps managed by the server
r.Methods("POST").Path("/v1/apps").Handler(httptransport.NewServer(
r.Methods("PUT").Path("/v1/apps").Handler(httptransport.NewServer(
e.AppUploadEndpoint,
decodeAppUploadRequest,
httputil.EncodeJSONResponse,
options...,
))
r.Methods("GET").Path("/v1/apps").Handler(httptransport.NewServer(
r.Methods("POST").Path("/v1/apps").Handler(httptransport.NewServer(
e.ListAppsEndpoint,
decodeListAppsRequest,
httputil.EncodeJSONResponse,