Commit Graph

403 Commits

Author SHA1 Message Date
Justin Clarke Casey
451a5bbf30 * Put in crude poll waiting for 60 seconds for delayed user inventory delivery from the inventory service
* This will reduce failures where the inventory server is simply slow
* Still need to properly inform the user if the inventory service has failed altogether
2008-04-13 22:09:07 +00:00
Justin Clarke Casey
7bfd7e6f08 * Remove the worst excesses of my inventory debugging code 2008-04-11 18:58:09 +00:00
Justin Clarke Casey
7ac7f79f88 * Eliminate a class of errors where an inventory request could be made before the region had completely received the inventory for the user.
* A much larger race condition where the inventory request could be made before the region gets any data at all will also be fixed in the near future.
* This change also fixes a regression from two patches ago where items stopped appearing in standalone inventory
2008-04-11 18:46:54 +00:00
Justin Clarke Casey
649f304e76 * Minor inventory code cleanup following on from last patch 2008-04-11 18:19:21 +00:00
Justin Clarke Casey
a5176c2e2c * Change inventory async response deliver to deliver all items and folders at once, rather than each individual
* This is required in order to work towards eliminating some inventory race conditions and to better deal with situations where a grid inventory server is slow or not responding.
2008-04-11 18:13:10 +00:00
Justin Clarke Casey
e26d4fc085 * minor: replace test of CachedUserInfo.RootFolder != null with something more readable, and make RootFolder get only 2008-04-11 17:02:20 +00:00
Justin Clarke Casey
205b95f2e8 * minor documenting, cleanup, renaming in user profile cache service 2008-04-11 16:49:20 +00:00
Justin Clarke Casey
576db5b72a * documenting and minor refactoring in UserProfileCacheService 2008-04-11 16:30:58 +00:00
Justin Clarke Casey
9a7717743b refactor: eliminate method in UserProfileCacheService 2008-04-11 16:13:33 +00:00
Justin Clarke Casey
b41abbd50e * Minor: really just comment and subsequent indentation adjustment. Preparation for handling inventory problems where the inventory server receives a request and never responds, or is late in responding 2008-04-10 17:44:19 +00:00
Sean Dague
25fea01b92 further renaming of properties for clarity 2008-04-10 14:09:30 +00:00
Sean Dague
c176caeb05 moved fields to properties for UserDataProfile, which was
actually a little more work than I expected given the copious
use of out params.
2008-04-10 13:53:06 +00:00
Sean Dague
a6d27e0929 further refactor and rename of InventoryFolderBase properties
to reflect what they really are.
2008-04-08 23:26:31 +00:00
Justin Clarke Casey
8eab365e21 * Adjust some inventory lookup failure messages to reduce confusion as to what just went wrong 2008-04-08 20:31:36 +00:00
Sean Dague
5ee75998ce more refactoring, this time on InventoryFolderBase
* wrap attributes in properties
 * clean up names a little bit
 * clean up name styles
2008-04-07 23:27:05 +00:00
Sean Dague
f436815107 Refactor InventoryItemBase to do the following:
* wrap fields as Properties
 * rename some fields/properties to more sensible names
 * set style to PropName to match more standard C# approach
2008-04-07 23:15:35 +00:00
Justin Clarke Casey
57afbdbdbd From: Kurt Taylor <krtaylor@us.ibm.com>
Patch to remove commented NotImpemented calls from within implemented script functions
2008-04-04 19:09:56 +00:00
Justin Clarke Casey
d53dd8a7cc * Minor change on region grid asset client to change two store log messages to one 2008-03-31 14:19:40 +00:00
Justin Clarke Casey
875211b262 * Various 1.19.0.5 grid inventory request fixes. These will only take affect once the region and the grid servers have upgraded to this revision
* You may also need to clear your cache before seeing any effect.
* These fixes may or may not affect inventory on the RC client.
* These fixes should make non-root folders work better, stop inventory failure on first login, allow trash to be emptied and make texture picker in object edit view work properly
* Fixes are 1) make initial root folder request wait for async inventory delivery, 2) deliver all folders in the initial login skeleton, not just the root child ones and 3) deal 
with situations where we receive child folders from the inventory service before their parent is received.
2008-03-29 22:18:44 +00:00
Justin Clarke Casey
0a47a75b88 * Send full inventory folder skeleton to standalone client logins rather than just the root child folders
* This may resolve some current problems with non root child folders on standalone installations.
* A fix for the same problem in grid mode will come soon.
2008-03-28 19:35:01 +00:00
Justin Clarke Casey
18f9f1410d * Just inserting some exploratory comments into inventory code 2008-03-18 18:19:44 +00:00
Jeff Ames
47180080f0 Formatting cleanup. 2008-03-18 05:16:43 +00:00
MW
c04899b60a Part 2 of fixing inventory for client 1.19.1 (RC), inventory items should now show up.
Most likely still some problems and most like needs some more work (and still a couple of things to finish off).
2008-03-15 12:53:03 +00:00
Justin Clarke Casey
42123770de * Add comments and slight corrections to ClientView.AgentTextureCached
* Reduce 'asset not found' console debug spam
2008-03-12 17:02:08 +00:00
Justin Clarke Casey
956f7cb4f9 * Very minor error message change in GridAssetClient 2008-03-11 17:55:49 +00:00
MW
70ad5604cd disabled AssetDownloadModule and re-enabled the asset download code in the asset cache, until it can be seen if the module was the cause of some new problems that seem like they might be related to assets. I'll look into this more tomorrow. 2008-02-27 22:47:33 +00:00
MW
2c65c2da90 small fix in the showstate data in AssetCache to reflect that now some functions are no longer in AssetCache 2008-02-27 21:32:01 +00:00
MW
e978d00914 After seeing sdague do his happy dance over trunk working "the best he has ever seen". I'm not sure I should be doing this commit, but oh well.
So anyway, it moves the Asset downloading (packet sending) to a module (AssetDownloadModule). 
So now at last, AssetCache should be just dealing with fetching assets from the asset server and caching them.
2008-02-27 21:11:01 +00:00
MW
aac7c1dda5 another attempt at fixing asset lockups 2008-02-27 16:20:45 +00:00
MW
a9ae5ab840 Hopefully fixed the bug that was causing a lot of the freezing. Which was happening due to locks in the AssetCache and Texturedownload module. Where the thread from the Asset thread would be take a lock on a list in the asset cache and then try to call the Callback into the texturedownload module and hit a lock in there which was held by a ClientView thread- which at the same time would be trying to request another texture from the cache and be hitting the lock in there held by the IClientAPI. The result each thread waiting for the other one to release a lock. And as one of those was the ClientView process packet thread. No more packets from that client could be processed. For now I've made a copy of the list in AssetCache so that it can release the lock. I'm doing more work on assets (moving the client asset downloading to a module ), so will hopefully change this into a better method once I've cleaned over things up a bit. 2008-02-27 14:40:30 +00:00
Justin Clarke Casey
65862aacea * Start sending "ImageNotFound" packet back to the client if we can't find an image
* This might stop some client's constant requests for unfound textures, which is a candidate for the memory leak
* If a texture is not found then the "Image not found" texture will now be displayed clientside
* If it works, this should resolve mantis 676
* Non texture image requests do not receive this packet yet
* This will require a prebuild
2008-02-25 23:26:35 +00:00
Justin Clarke Casey
f95ad65189 * Improve alignment of packet queue stats headigns
* Correct asset cache stats table heading
* Correct spelling mistake in AssetCache (thanks ChrisD!)
2008-02-22 23:15:00 +00:00
Justin Clarke Casey
fed46ba6a7 * Winnow the debug and info messages associated with stat fetching
* As such, only a request for a non cached asset, the response and failures show up now.
* I know lbsa71 only put these in not long ago, so if they are really still required, I think we should think whether we can move the default log4net level off 'Debug'
2008-02-22 22:54:50 +00:00
Tedd Hansen
7102ac7769 "threads" command now works. I've added manual tracking of threads (only if compiled in DEBUG mode)... Its ugly and even requires a separate thread to track the treads, but it will be very valuable in debugging. 2008-02-21 10:43:24 +00:00
Justin Clarke Casey
b0c5ef0b68 * Eliminate AssetCache.CopyAsset()
* Resolve a bad logic bug in AssetCache.GetAsset()
* This may make some asset related things work better (possibly getting main map images will now be improved).
2008-02-20 23:21:51 +00:00
Justin Clarke Casey
7d7ad4dff2 * Only count download requests for assets which are not already waiting for data from the asset server
* This should stop the constant increase in the download requests statistics
* If you see stat numbers for download requests which are far from what you'd expect, please report
2008-02-20 20:23:03 +00:00
Justin Clarke Casey
f3190810d3 * Properly guard removal of asset request lists on AssetCache.AssetNotFound (my own bug) 2008-02-20 19:13:59 +00:00
Justin Clarke Casey
53d5aeec24 * Remove unused texture dictionaries from AssetCache
* Add documentation to AssetCache
2008-02-20 19:02:04 +00:00
Jeff Ames
a8cfbbe963 Minor cleanup. 2008-02-20 18:38:20 +00:00
Justin Clarke Casey
c66b5a9e71 Report command string on ConsoleBase.RunCommand exception 2008-02-20 17:54:14 +00:00
Justin Clarke Casey
877713999c * Report 'asset not found' situations back to UserTextureDownloadService
* This fixes some of the 'runaway downloads' problem but not all of it
* Also fix up logging messages so texture requests are reported as such rather than as assets
2008-02-20 17:34:10 +00:00
lbsa71
4c6e5a5090 * re-enabled AssetNotFound code
* turned script asset fetching asynchronous
2008-02-20 13:11:19 +00:00
lbsa71
9be5f9d6cc * Fixed xml loading bug (the xml was scheduled for update before added to a scene)
* Fixed ClickAction situation on the same note (properties shouldn't cause big changes)
* Added some more debug output to AssetCache
2008-02-20 09:38:45 +00:00
Tedd Hansen
47c909ca0a Playing "Name that thread". Adding names and isbackground=true to all threads so it will be easier to debug. 2008-02-19 12:02:53 +00:00
MW
b618802e53 Moved the AgentAssetTransactionsManager (and AgentAssetTransactions) out of CommsManager and into a module (AgentAgentTransactionModule), still needs cleaning up though.
But its one more thing out of the CommsManager. One day we will kill the CommsManager!
2008-02-16 13:01:42 +00:00
Jeff Ames
001ce95e4c Clean up more unnecessary String.Format calls 2008-02-13 03:38:18 +00:00
Justin Clarke Casey
a1a206cb05 * Clean up LIBRARY INVENTORY messages 2008-02-13 02:43:41 +00:00
Justin Clarke Casey
45638cc141 Commenting and a spelling correction 2008-02-13 01:04:27 +00:00
Justin Clarke Casey
1677bde480 * Clean up the agent's asset transactions when it is removed from the scene
* This may or may not help with the memory leak, need to assess
2008-02-13 00:52:49 +00:00
Justin Clarke Casey
365cf8e455 * Refactor: Move last commit's refactor back to AgentAssetTransactionsManager
* Push asset update (invoked when clothing is altered) down into AgentAssetTransactions from Scene.Inventory.cs to join others
* I've tested that clothing creation and update still works, but please let me know if it suddently breaks for you.
* Add/correct comments
2008-02-13 00:30:51 +00:00